Re: [Qemu-devel] Re: [PATCH 2/3] target-sparc: Free instruction temporaries.

2010-04-18 Thread Richard Henderson
On 04/17/2010 01:41 PM, Blue Swirl wrote: > Yes, but we would still gain the small optimizations for add by 0, and > with 0x etc. in tcg-op.h. Sparc QEMU target generates a lot of > those because of poor constant formation choices made by the guest > compilers. Another thing that gets fixe

Re: [Qemu-devel] Re: [PATCH 2/3] target-sparc: Free instruction temporaries.

2010-04-17 Thread Blue Swirl
On 4/17/10, Richard Henderson wrote: > On 04/17/2010 12:49 PM, Richard Henderson wrote: > > On 04/17/2010 11:41 AM, Blue Swirl wrote: > >> About this patch: it's good that we now free the constants, but > >> constant handling is still not optimal and I think this series > >> actually may add e

Re: [Qemu-devel] Re: [PATCH 2/3] target-sparc: Free instruction temporaries.

2010-04-17 Thread Blue Swirl
On 4/17/10, Richard Henderson wrote: > On 04/17/2010 11:41 AM, Blue Swirl wrote: > > About this patch: it's good that we now free the constants, but > > constant handling is still not optimal and I think this series > > actually may add extra 'movi' ops in the worst case. It would be nice > >

Re: [Qemu-devel] Re: [PATCH 2/3] target-sparc: Free instruction temporaries.

2010-04-17 Thread Richard Henderson
On 04/17/2010 12:49 PM, Richard Henderson wrote: > On 04/17/2010 11:41 AM, Blue Swirl wrote: >> About this patch: it's good that we now free the constants, but >> constant handling is still not optimal and I think this series >> actually may add extra 'movi' ops in the worst case. It would be nice

Re: [Qemu-devel] Re: [PATCH 2/3] target-sparc: Free instruction temporaries.

2010-04-17 Thread Richard Henderson
On 04/17/2010 11:41 AM, Blue Swirl wrote: > About this patch: it's good that we now free the constants, but > constant handling is still not optimal and I think this series > actually may add extra 'movi' ops in the worst case. It would be nice > if we detected if constants are in play and call imm

[Qemu-devel] Re: [PATCH 2/3] target-sparc: Free instruction temporaries.

2010-04-17 Thread Blue Swirl
On 4/16/10, Richard Henderson wrote: > Rather than creating new temporaries for constants, use the > ones created in disas_sparc_insn. Remember the temps created > there so that they can be freed at the end of the function. > > Profile data collected by TCG while booting sparc-test kernel: > >