[Qemu-devel] Re: [PATCH 16/28] migration: use global variable directly

2011-02-24 Thread Paolo Bonzini
On 02/24/2011 08:09 AM, Markus Armbruster wrote: For completeness: a local variable may be necessary to convince the optimizer that the value doesn't change. Cases where this matters exist, but they're rare. In particular, for non-pointers they're nonexistent if the variable is static and you

Re: [Qemu-devel] Re: [PATCH 16/28] migration: use global variable directly

2011-02-23 Thread Markus Armbruster
Anthony Liguori writes: > On 02/23/2011 04:46 PM, Juan Quintela wrote: >> Anthony Liguori wrote: >> >>> On 02/23/2011 03:47 PM, Juan Quintela wrote: >>> We are setting a pointer to a local variable in the previous line, just use the global variable directly. We remove the ->

[Qemu-devel] Re: [PATCH 16/28] migration: use global variable directly

2011-02-23 Thread Juan Quintela
Anthony Liguori wrote: > On 02/23/2011 04:46 PM, Juan Quintela wrote: >> Anthony Liguori wrote: >> >>> On 02/23/2011 03:47 PM, Juan Quintela wrote: >>> We are setting a pointer to a local variable in the previous line, just use the global variable directly. We remove the ->fi

[Qemu-devel] Re: [PATCH 16/28] migration: use global variable directly

2011-02-23 Thread Anthony Liguori
On 02/23/2011 04:46 PM, Juan Quintela wrote: Anthony Liguori wrote: On 02/23/2011 03:47 PM, Juan Quintela wrote: We are setting a pointer to a local variable in the previous line, just use the global variable directly. We remove the ->file test because it is already done inside qemu

[Qemu-devel] Re: [PATCH 16/28] migration: use global variable directly

2011-02-23 Thread Juan Quintela
Anthony Liguori wrote: > On 02/23/2011 03:47 PM, Juan Quintela wrote: >> We are setting a pointer to a local variable in the previous line, just use >> the global variable directly. We remove the ->file test because it is >> already >> done inside qemu_file_set_rate_limit() function. >> > >