Re: [Qemu-devel] Re: [PATCH 10/16] scsi: Use 'SCSIRequest' directly

2010-11-19 Thread Gerd Hoffmann
On 11/18/10 17:33, Hannes Reinecke wrote: Not sure if it makes sense to split it up into several patches; we need the ->get_req()/->put_req() callbacks to get the request in the first place. Point. And only then can we modify the other callbacks. However, splitting them off into two patchsets

Re: [Qemu-devel] Re: [PATCH 10/16] scsi: Use 'SCSIRequest' directly

2010-11-18 Thread Hannes Reinecke
On 11/18/2010 05:16 PM, Gerd Hoffmann wrote: > On 11/18/10 15:47, Hannes Reinecke wrote: >> >> Rather than to access a SCSIRequest via an abstract 'tag' we can >> as well use it directly and save us the lookup. > > Hmm. Looks like a few more request handling changes than a pure > s/tag/req/ + zap

[Qemu-devel] Re: [PATCH 10/16] scsi: Use 'SCSIRequest' directly

2010-11-18 Thread Gerd Hoffmann
On 11/18/10 15:47, Hannes Reinecke wrote: Rather than to access a SCSIRequest via an abstract 'tag' we can as well use it directly and save us the lookup. Hmm. Looks like a few more request handling changes than a pure s/tag/req/ + zap lookups sneaked into that patch. There are new get_req