Re: [Qemu-devel] Re: [PATCH 1/3] cursor: add cursor functions.

2010-05-20 Thread Anthony Liguori
On 05/20/2010 07:49 AM, Gerd Hoffmann wrote: Hi, Well. You can't have both. We can have a efficiently packed format (i.e. two bitmaps). Or we can do it in a way which doesn't need parsing, but that wouldn't be the most compact format ... You're right, so packing or introducing a small conve

Re: [Qemu-devel] Re: [PATCH 1/3] cursor: add cursor functions.

2010-05-20 Thread Gerd Hoffmann
Hi, Well. You can't have both. We can have a efficiently packed format (i.e. two bitmaps). Or we can do it in a way which doesn't need parsing, but that wouldn't be the most compact format ... You're right, so packing or introducing a small conversion function is not critical. I'd still prefe

Re: [Qemu-devel] Re: [PATCH 1/3] cursor: add cursor functions.

2010-05-19 Thread Anthony Liguori
On 05/19/2010 01:57 PM, Blue Swirl wrote: On 5/19/10, Gerd Hoffmann wrote: Then there would be no need of parsing. You would need _two_ bitmaps (e.g. mask and cursor, so that mask=1 gives transparent, mask=0 cursor=0 gives black and mask=0

[Qemu-devel] Re: [PATCH 1/3] cursor: add cursor functions.

2010-05-19 Thread Blue Swirl
On 5/19/10, Gerd Hoffmann wrote: > > > > > > > > > Then there would be no need of parsing. > > > > > > > > > > You would need _two_ bitmaps (e.g. mask and cursor, so that mask=1 > gives > > > transparent, mask=0 cursor=0 gives black and mask=0 cursor=1 gives > white). > > > > > > > Yes, but it's

[Qemu-devel] Re: [PATCH 1/3] cursor: add cursor functions.

2010-05-19 Thread Gerd Hoffmann
Then there would be no need of parsing. You would need _two_ bitmaps (e.g. mask and cursor, so that mask=1 gives transparent, mask=0 cursor=0 gives black and mask=0 cursor=1 gives white). Yes, but it's still packed more efficiently. Well. You can't have both. We can have a efficiently pa

[Qemu-devel] Re: [PATCH 1/3] cursor: add cursor functions.

2010-05-07 Thread Blue Swirl
On 5/7/10, Paolo Bonzini wrote: > On 05/06/2010 08:12 PM, Blue Swirl wrote: > > > On 5/5/10, Gerd Hoffmann wrote: > > > > > Add a new cursor type to console.h and a bunch of functions to > > > deal with cursors the (new) cursor.c file. > > > > > > Signed-off-by: Gerd Hoffmann > > > --- > > >

[Qemu-devel] Re: [PATCH 1/3] cursor: add cursor functions.

2010-05-07 Thread Paolo Bonzini
On 05/06/2010 08:12 PM, Blue Swirl wrote: On 5/5/10, Gerd Hoffmann wrote: Add a new cursor type to console.h and a bunch of functions to deal with cursors the (new) cursor.c file. Signed-off-by: Gerd Hoffmann --- Makefile.objs |3 +- console.h | 24 ++- cursor.c