Re: [Qemu-devel] Re: [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled()

2010-10-20 Thread Blue Swirl
On Mon, Oct 18, 2010 at 2:16 PM, Anthony Liguori wrote: > On 10/18/2010 03:22 AM, Roedel, Joerg wrote: >> >> (Sorry for the late reply) >> >> On Thu, Oct 07, 2010 at 08:48:06AM -0400, Anthony Liguori wrote: >> >>> >>> On 10/07/2010 03:42 AM, Roedel, Joerg wrote: >>> On Wed, Oct 06, 2010

[Qemu-devel] Re: [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled()

2010-10-18 Thread Anthony Liguori
On 10/18/2010 03:22 AM, Roedel, Joerg wrote: (Sorry for the late reply) On Thu, Oct 07, 2010 at 08:48:06AM -0400, Anthony Liguori wrote: On 10/07/2010 03:42 AM, Roedel, Joerg wrote: On Wed, Oct 06, 2010 at 03:24:59PM -0400, Anthony Liguori wrote: +qemu_compat_version =

[Qemu-devel] Re: [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled()

2010-10-18 Thread Roedel, Joerg
(Sorry for the late reply) On Thu, Oct 07, 2010 at 08:48:06AM -0400, Anthony Liguori wrote: > On 10/07/2010 03:42 AM, Roedel, Joerg wrote: > > On Wed, Oct 06, 2010 at 03:24:59PM -0400, Anthony Liguori wrote: > > > +qemu_compat_version = machine->compat_version; > + >

[Qemu-devel] Re: [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled()

2010-10-07 Thread Anthony Liguori
On 10/07/2010 03:42 AM, Roedel, Joerg wrote: On Wed, Oct 06, 2010 at 03:24:59PM -0400, Anthony Liguori wrote: +qemu_compat_version = machine->compat_version; + if (display_type == DT_NOGRAPHIC) { if (default_parallel) add_device_config(DEV_PARALLEL, "null

[Qemu-devel] Re: [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled()

2010-10-07 Thread Roedel, Joerg
On Wed, Oct 06, 2010 at 03:24:59PM -0400, Anthony Liguori wrote: > >> +qemu_compat_version = machine->compat_version; > >> + > >> if (display_type == DT_NOGRAPHIC) { > >> if (default_parallel) > >> add_device_config(DEV_PARALLEL, "null"); > >> -- > >> 1.7.0.4 > >>

[Qemu-devel] Re: [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled()

2010-10-06 Thread Anthony Liguori
On 10/06/2010 01:53 PM, Marcelo Tosatti wrote: On Mon, Sep 27, 2010 at 03:16:15PM +0200, Joerg Roedel wrote: As requested by Alex this patch makes kvm64 the default CPU model when qemu is started with -enable-kvm. This takes only effect for qemu-versions newer or equal to 0.14.0. Signed-off

[Qemu-devel] Re: [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled()

2010-10-06 Thread Marcelo Tosatti
On Mon, Sep 27, 2010 at 03:16:15PM +0200, Joerg Roedel wrote: > As requested by Alex this patch makes kvm64 the default CPU > model when qemu is started with -enable-kvm. This takes only > effect for qemu-versions newer or equal to 0.14.0. > > Signed-off-by: Joerg Roedel > --- > hw/boards.h|

[Qemu-devel] Re: [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled()

2010-09-16 Thread Avi Kivity
On 09/16/2010 04:21 PM, Roedel, Joerg wrote: On Thu, Sep 16, 2010 at 10:03:19AM -0400, Avi Kivity wrote: >On 09/14/2010 05:52 PM, Joerg Roedel wrote: > > As requested by Alex this patch makes kvm64 the default CPU > > model when qemu is started with -enable-kvm. > > > > > > This break

[Qemu-devel] Re: [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled()

2010-09-16 Thread Roedel, Joerg
On Thu, Sep 16, 2010 at 10:03:19AM -0400, Avi Kivity wrote: > On 09/14/2010 05:52 PM, Joerg Roedel wrote: > > As requested by Alex this patch makes kvm64 the default CPU > > model when qemu is started with -enable-kvm. > > > > > > This breaks compatiblity; if started with -M 0.13 or prior we sho

[Qemu-devel] Re: [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled()

2010-09-16 Thread Avi Kivity
On 09/14/2010 05:52 PM, Joerg Roedel wrote: As requested by Alex this patch makes kvm64 the default CPU model when qemu is started with -enable-kvm. This breaks compatiblity; if started with -M 0.13 or prior we should default to qemu64. -- error compiling committee.c: too many arguments t

[Qemu-devel] Re: [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled()

2010-09-14 Thread Roedel, Joerg
On Tue, Sep 14, 2010 at 11:58:03AM -0400, Alexander Graf wrote: > > +if (kvm_enabled()) > > +cpu_model = DEFAULT_KVM_CPU_MODEL; > > +else > > +cpu_model = DEFAULT_QEMU_CPU_MODEL; > > > > Braces :(. Okay, here is the new patch: >From f49e78edbd4143d0512

[Qemu-devel] Re: [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled()

2010-09-14 Thread Alexander Graf
Joerg Roedel wrote: > As requested by Alex this patch makes kvm64 the default CPU > model when qemu is started with -enable-kvm. > > Signed-off-by: Joerg Roedel > --- > hw/pc.c | 19 ++- > 1 files changed, 14 insertions(+), 5 deletions(-) > > diff --git a/hw/pc.c b/hw/pc.c > ind