Re: [Qemu-devel] Re: [PATCH 1/2] QMP: Introduce commands doc

2010-05-18 Thread Luiz Capitulino
On Tue, 18 May 2010 13:21:36 +0200 Markus Armbruster wrote: > Jan Kiszka writes: [...] > > nothing needs to be delayed any further. > > Well, it's being delayed :) > > Let's commit the sucker as is. We can still move it into > qemu-monitor.hx afterwards. Commits are cheap, waiting for the

Re: [Qemu-devel] Re: [PATCH 1/2] QMP: Introduce commands doc

2010-05-18 Thread Markus Armbruster
Jan Kiszka writes: > Luiz Capitulino wrote: >> On Fri, 14 May 2010 19:08:07 +0200 >> Jan Kiszka wrote: >> >>> Avi Kivity wrote: On 05/14/2010 08:01 PM, Avi Kivity wrote: > On 05/14/2010 07:52 PM, Jan Kiszka wrote: >>> In order not to compromise QMP adoption and make users' life eas

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce commands doc

2010-05-17 Thread Luiz Capitulino
On Sat, 15 May 2010 10:42:44 +0200 Jan Kiszka wrote: > Luiz Capitulino wrote: > > On Fri, 14 May 2010 19:08:07 +0200 > > Jan Kiszka wrote: > > > >> Avi Kivity wrote: > >>> On 05/14/2010 08:01 PM, Avi Kivity wrote: > On 05/14/2010 07:52 PM, Jan Kiszka wrote: > >> In order not to comprom

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce commands doc

2010-05-15 Thread Jan Kiszka
Luiz Capitulino wrote: > On Fri, 14 May 2010 19:08:07 +0200 > Jan Kiszka wrote: > >> Avi Kivity wrote: >>> On 05/14/2010 08:01 PM, Avi Kivity wrote: On 05/14/2010 07:52 PM, Jan Kiszka wrote: >> In order not to compromise QMP adoption and make users' life easier, >> this commit adds a

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Luiz Capitulino
On Fri, 14 May 2010 19:08:07 +0200 Jan Kiszka wrote: > Avi Kivity wrote: > > On 05/14/2010 08:01 PM, Avi Kivity wrote: > >> On 05/14/2010 07:52 PM, Jan Kiszka wrote: > In order not to compromise QMP adoption and make users' life easier, > this commit adds a simple text documentation whi

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Avi Kivity
On 05/14/2010 08:08 PM, Jan Kiszka wrote: I mean, a patch introducing or modifying a monitor command. The snippets should be readable by themselves. They may be readable, but that doesn't mean anyone will read them. It's a lot easier for someone who isn't involved in the code (the li

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Jan Kiszka
Avi Kivity wrote: > On 05/14/2010 08:01 PM, Avi Kivity wrote: >> On 05/14/2010 07:52 PM, Jan Kiszka wrote: In order not to compromise QMP adoption and make users' life easier, this commit adds a simple text documentation which fully describes all QMP supported commands. Thi

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Avi Kivity
On 05/14/2010 08:01 PM, Avi Kivity wrote: On 05/14/2010 07:52 PM, Jan Kiszka wrote: In order not to compromise QMP adoption and make users' life easier, this commit adds a simple text documentation which fully describes all QMP supported commands. This is not ideal for a number of reasons (ha

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Avi Kivity
On 05/14/2010 07:52 PM, Jan Kiszka wrote: In order not to compromise QMP adoption and make users' life easier, this commit adds a simple text documentation which fully describes all QMP supported commands. This is not ideal for a number of reasons (harder to maintain, text-only, etc) but does

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Jan Kiszka
Luiz Capitulino wrote: > One of the most important missing feature in QMP today is its > supported commands documentation. > > The plan is to make it part of self-description support, however > self-description is a big task we have been postponing for a > long time now and still don't know when i