[Qemu-devel] Re: [PATCH 09/13] ahci: add ahci emulation

2010-12-10 Thread Kevin Wolf
Am 09.12.2010 17:18, schrieb Alexander Graf: > Kevin Wolf wrote: >> Am 09.12.2010 16:48, schrieb Alexander Graf: >> > +static void ncq_cb(void *opaque, int ret) > +{ > +NCQTransferState *ncq_tfs = (NCQTransferState *)opaque; > +IDEState *ide_state; > + > +if (

[Qemu-devel] Re: [PATCH 09/13] ahci: add ahci emulation

2010-12-09 Thread Kevin Wolf
Am 09.12.2010 16:48, schrieb Alexander Graf: >>> +static void ncq_cb(void *opaque, int ret) >>> +{ >>> +NCQTransferState *ncq_tfs = (NCQTransferState *)opaque; >>> +IDEState *ide_state; >>> + >>> +if (ret < 0) { >>> +/* XXX error */ >>> +} >>> >> >> Missing error handli

[Qemu-devel] Re: [PATCH 09/13] ahci: add ahci emulation

2010-12-09 Thread Alexander Graf
Stefan Hajnoczi wrote: > On Wed, Dec 8, 2010 at 12:13 PM, Alexander Graf wrote: > >> +struct AHCIDevice { >> +IDEBus port; >> +int port_no; >> +uint32_t port_state; >> +uint32_t finished; >> +AHCIPortRegs port_regs; >> +struct AHCIState *hba; >> +uint8_t *lst; >> +

[Qemu-devel] Re: [PATCH 09/13] ahci: add ahci emulation

2010-12-09 Thread Alexander Graf
Kevin Wolf wrote: > Am 09.12.2010 16:48, schrieb Alexander Graf: > +static void ncq_cb(void *opaque, int ret) +{ +NCQTransferState *ncq_tfs = (NCQTransferState *)opaque; +IDEState *ide_state; + +if (ret < 0) { +/* XXX error */ +} >>

[Qemu-devel] Re: [PATCH 09/13] ahci: add ahci emulation

2010-12-09 Thread Stefan Hajnoczi
On Wed, Dec 8, 2010 at 12:13 PM, Alexander Graf wrote: > +struct AHCIDevice { > +    IDEBus port; > +    int port_no; > +    uint32_t port_state; > +    uint32_t finished; > +    AHCIPortRegs port_regs; > +    struct AHCIState *hba; > +    uint8_t *lst; > +    uint8_t *res_fis; > +    uint8_t *cmd