Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-21 Thread Markus Armbruster
Juan Quintela writes: > Gleb Natapov wrote: >> On Wed, Jan 20, 2010 at 09:14:03PM +0100, Juan Quintela wrote: [...] >>> diff --git a/block/vvfat.c b/block/vvfat.c >>> index 063f731..df957e5 100644 >>> --- a/block/vvfat.c >>> +++ b/block/vvfat.c >>> @@ -868,7 +868,8 @@ static int init_directories

[Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-21 Thread Gleb Natapov
On Thu, Jan 21, 2010 at 09:17:27AM +0100, Juan Quintela wrote: > Gleb Natapov wrote: > > On Wed, Jan 20, 2010 at 09:14:03PM +0100, Juan Quintela wrote: > >> From: Kirill A. Shutemov > >> > >> CCblock/vvfat.o > >> cc1: warnings being treated as errors > >> block/vvfat.c: In function 'commit_o

[Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-21 Thread Juan Quintela
Gleb Natapov wrote: > On Wed, Jan 20, 2010 at 09:14:03PM +0100, Juan Quintela wrote: >> From: Kirill A. Shutemov >> >> CCblock/vvfat.o >> cc1: warnings being treated as errors >> block/vvfat.c: In function 'commit_one_file': >> block/vvfat.c:2259: error: ignoring return value of 'ftruncate',

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-20 Thread Jamie Lokier
Kirill A. Shutemov wrote: > On Wed, Jan 20, 2010 at 3:03 PM, Markus Armbruster wrote: > > "Kirill A. Shutemov" writes: > >> No, compiler can't add anything between. 'char' is always byte-aligned. > > > > You got some reading to do then. > > Do you want to say that it's not true? Could you provid

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-20 Thread Anthony Liguori
On 01/20/2010 12:19 AM, Kirill A. Shutemov wrote: On Wed, Jan 20, 2010 at 1:56 AM, Juan Quintela wrote: From: Kirill A. Shutemov CCblock/vvfat.o cc1: warnings being treated as errors block/vvfat.c: In function 'commit_one_file': block/vvfat.c:2259: error: ignoring return value of 'ftru

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-20 Thread malc
On Wed, 20 Jan 2010, Kirill A. Shutemov wrote: > 2010/1/20 Gleb Natapov : > > On Wed, Jan 20, 2010 at 02:03:04PM +0100, Markus Armbruster wrote: > >> "Kirill A. Shutemov" writes: > >> > No, compiler can't add anything between. 'char' is always byte-aligned. > >> > >> You got some reading to do th

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-20 Thread Markus Armbruster
[Some quoted material restored] "Kirill A. Shutemov" writes: > On Wed, Jan 20, 2010 at 3:03 PM, Markus Armbruster wrote: >> "Kirill A. Shutemov" writes: >>> On Wed, Jan 20, 2010 at 2:15 PM, Markus Armbruster >>> wrote: Kevin Wolf writes: > Regardless if deliberately overflowing the

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-20 Thread Gleb Natapov
On Wed, Jan 20, 2010 at 04:02:19PM +0200, Kirill A. Shutemov wrote: > 2010/1/20 Gleb Natapov : > > On Wed, Jan 20, 2010 at 02:03:04PM +0100, Markus Armbruster wrote: > >> "Kirill A. Shutemov" writes: > >> > No, compiler can't add anything between. 'char' is always byte-aligned. > >> > >> You got s

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-20 Thread Kirill A. Shutemov
2010/1/20 Gleb Natapov : > On Wed, Jan 20, 2010 at 02:03:04PM +0100, Markus Armbruster wrote: >> "Kirill A. Shutemov" writes: >> > No, compiler can't add anything between. 'char' is always byte-aligned. >> >> You got some reading to do then. >> > To be fair this structure is packed, but this is no

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-20 Thread Kirill A. Shutemov
On Wed, Jan 20, 2010 at 3:03 PM, Markus Armbruster wrote: > "Kirill A. Shutemov" writes: >> No, compiler can't add anything between. 'char' is always byte-aligned. > > You got some reading to do then. Do you want to say that it's not true? Could you provide an example when 'char' isn't byte-alig

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-20 Thread Gleb Natapov
On Wed, Jan 20, 2010 at 02:03:04PM +0100, Markus Armbruster wrote: > "Kirill A. Shutemov" writes: > > > On Wed, Jan 20, 2010 at 2:15 PM, Markus Armbruster > > wrote: > >> Kevin Wolf writes: > >> > >>> Am 20.01.2010 12:09, schrieb Kirill A. Shutemov: > On Wed, Jan 20, 2010 at 12:33 PM, Dan

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-20 Thread Markus Armbruster
"Kirill A. Shutemov" writes: > On Wed, Jan 20, 2010 at 2:15 PM, Markus Armbruster wrote: >> Kevin Wolf writes: >> >>> Am 20.01.2010 12:09, schrieb Kirill A. Shutemov: On Wed, Jan 20, 2010 at 12:33 PM, Daniel P. Berrange wrote: > On Wed, Jan 20, 2010 at 08:19:26AM +0200, Kirill A.

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-20 Thread Kirill A. Shutemov
On Wed, Jan 20, 2010 at 2:15 PM, Markus Armbruster wrote: > Kevin Wolf writes: > >> Am 20.01.2010 12:09, schrieb Kirill A. Shutemov: >>> On Wed, Jan 20, 2010 at 12:33 PM, Daniel P. Berrange >>> wrote: On Wed, Jan 20, 2010 at 08:19:26AM +0200, Kirill A. Shutemov wrote: > On Wed, Jan 20,

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-20 Thread Markus Armbruster
Kevin Wolf writes: > Am 20.01.2010 12:09, schrieb Kirill A. Shutemov: >> On Wed, Jan 20, 2010 at 12:33 PM, Daniel P. Berrange >> wrote: >>> On Wed, Jan 20, 2010 at 08:19:26AM +0200, Kirill A. Shutemov wrote: On Wed, Jan 20, 2010 at 1:56 AM, Juan Quintela wrote: [...] > diff --git a/blo

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-20 Thread Kevin Wolf
Am 20.01.2010 12:09, schrieb Kirill A. Shutemov: > On Wed, Jan 20, 2010 at 12:33 PM, Daniel P. Berrange > wrote: >> On Wed, Jan 20, 2010 at 08:19:26AM +0200, Kirill A. Shutemov wrote: >>> On Wed, Jan 20, 2010 at 1:56 AM, Juan Quintela wrote: From: Kirill A. Shutemov CCblock/vv

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-20 Thread Kirill A. Shutemov
On Wed, Jan 20, 2010 at 12:33 PM, Daniel P. Berrange wrote: > On Wed, Jan 20, 2010 at 08:19:26AM +0200, Kirill A. Shutemov wrote: >> On Wed, Jan 20, 2010 at 1:56 AM, Juan Quintela wrote: >> > From: Kirill A. Shutemov >> > >> > CC    block/vvfat.o >> > cc1: warnings being treated as errors >> > b

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-20 Thread Daniel P. Berrange
On Wed, Jan 20, 2010 at 08:19:26AM +0200, Kirill A. Shutemov wrote: > On Wed, Jan 20, 2010 at 1:56 AM, Juan Quintela wrote: > > From: Kirill A. Shutemov > > > > CC    block/vvfat.o > > cc1: warnings being treated as errors > > block/vvfat.c: In function 'commit_one_file': > > block/vvfat.c:2259:

[Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-19 Thread Kirill A. Shutemov
On Wed, Jan 20, 2010 at 1:56 AM, Juan Quintela wrote: > From: Kirill A. Shutemov > > CC    block/vvfat.o > cc1: warnings being treated as errors > block/vvfat.c: In function 'commit_one_file': > block/vvfat.c:2259: error: ignoring return value of 'ftruncate', declared > with attribute warn_unuse