[Qemu-devel] Re: [PATCH 07/14] msi: implemented msi.

2010-09-08 Thread Michael S. Tsirkin
On Wed, Sep 08, 2010 at 04:43:27PM +0900, Isaku Yamahata wrote: > Thank you for through review. > > On Mon, Sep 06, 2010 at 12:44:16PM +0300, Michael S. Tsirkin wrote: > > > +uint32_t pending = > > > +pci_get_long(dev->config + msi_pending_reg(dev, is64bit)); > > > +uin

[Qemu-devel] Re: [PATCH 07/14] msi: implemented msi.

2010-09-08 Thread Isaku Yamahata
Thank you for through review. On Mon, Sep 06, 2010 at 12:44:16PM +0300, Michael S. Tsirkin wrote: > > +uint32_t pending = > > +pci_get_long(dev->config + msi_pending_reg(dev, is64bit)); > > +uint8_t vector; > > + > > +/* deliver pending interrupts which are unma

[Qemu-devel] Re: [PATCH 07/14] msi: implemented msi.

2010-09-06 Thread Michael S. Tsirkin
On Mon, Sep 06, 2010 at 04:46:21PM +0900, Isaku Yamahata wrote: > implemented msi support functions. > > Signed-off-by: Isaku Yamahata Good stuff. Below I suggest a couple of minor correctness issues, and a couple of API changes. Below are also some suggestions to improve readability a bit: mo