[Qemu-devel] Re: [PATCH 04/11] qerror: split out the reporting bits of QError

2011-03-14 Thread Anthony Liguori
On 03/14/2011 02:30 PM, Luiz Capitulino wrote: libqmp It's very nice to have client code that convert QMP errors to human readable strings. Ok. I'm not sure if I would bother doing this kind of change in this series (as it's mainly re-working internal stuff) but, this has to be explained in th

[Qemu-devel] Re: [PATCH 04/11] qerror: split out the reporting bits of QError

2011-03-14 Thread Luiz Capitulino
On Mon, 14 Mar 2011 14:24:37 -0500 Anthony Liguori wrote: > On 03/14/2011 02:18 PM, Luiz Capitulino wrote: > > On Fri, 11 Mar 2011 15:00:42 -0600 > > Anthony Liguori wrote: > > > >> These make it very hard to compile QError outside of QEMU. > > Why would someone do this? > > libqmp > > It's ve

[Qemu-devel] Re: [PATCH 04/11] qerror: split out the reporting bits of QError

2011-03-14 Thread Luiz Capitulino
On Fri, 11 Mar 2011 15:00:42 -0600 Anthony Liguori wrote: > These make it very hard to compile QError outside of QEMU. Why would someone do this? > > Signed-off-by: Anthony Liguori > > diff --git a/Makefile.objs b/Makefile.objs > index da31530..69f0383 100644 > --- a/Makefile.objs > +++ b/Ma

[Qemu-devel] Re: [PATCH 04/11] qerror: split out the reporting bits of QError

2011-03-14 Thread Anthony Liguori
On 03/14/2011 02:18 PM, Luiz Capitulino wrote: On Fri, 11 Mar 2011 15:00:42 -0600 Anthony Liguori wrote: These make it very hard to compile QError outside of QEMU. Why would someone do this? libqmp It's very nice to have client code that convert QMP errors to human readable strings. Reg