On 18.05.2010, at 11:56, Corentin Chary wrote:
> On Tue, May 18, 2010 at 11:18 AM, Alexander Graf wrote:
>>
>> On 18.05.2010, at 09:31, Corentin Chary wrote:
>>
>> This is missing a patch description. When people later on either cherry-pick
>> your commits or simply git show them, it's almost
On Tue, May 18, 2010 at 11:19 AM, Alexander Graf wrote:
>
> On 18.05.2010, at 09:31, Corentin Chary wrote:
>
>> Signed-off-by: Corentin Chary
>
> I'm also missing a cover letter explaining what your patch set does. As a
> general rule of thumb, whenever your patch set spans more than 2 patches,
On 18.05.2010, at 11:53, Corentin Chary wrote:
> On Tue, May 18, 2010 at 11:19 AM, Alexander Graf wrote:
>>
>> On 18.05.2010, at 09:31, Corentin Chary wrote:
>>
>>> Signed-off-by: Corentin Chary
>>
>> I'm also missing a cover letter explaining what your patch set does. As a
>> general rule
On Tue, May 18, 2010 at 11:18 AM, Alexander Graf wrote:
>
> On 18.05.2010, at 09:31, Corentin Chary wrote:
>
> This is missing a patch description. When people later on either cherry-pick
> your commits or simply git show them, it's almost impossible to know what's
> going on.
> So please always
On 18.05.2010, at 09:31, Corentin Chary wrote:
> Signed-off-by: Corentin Chary
I'm also missing a cover letter explaining what your patch set does. As a
general rule of thumb, whenever your patch set spans more than 2 patches, a
cover letter is really helpful. To generate one, use git-format-
On 18.05.2010, at 09:31, Corentin Chary wrote:
This is missing a patch description. When people later on either cherry-pick
your commits or simply git show them, it's almost impossible to know what's
going on.
So please always put in a patch description.
Alex
> Signed-off-by: Corentin Chary
