Re: [Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-18 Thread Stefan Weil
Am 18.12.2010 13:02, schrieb Andreas Färber: Am 18.12.2010 um 11:19 schrieb Stefan Weil: Am 18.12.2010 00:24, schrieb Paolo Bonzini: On 12/17/2010 11:17 PM, Andreas Färber wrote: Example (needs bash's echo -e): # create line with crlf ending: echo -e 'include xy\r' >file # returns xy\r: awk

Re: [Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-18 Thread Andreas Färber
Am 18.12.2010 um 11:19 schrieb Stefan Weil: Am 18.12.2010 00:24, schrieb Paolo Bonzini: On 12/17/2010 11:17 PM, Andreas Färber wrote: Example (needs bash's echo -e): # create line with crlf ending: echo -e 'include xy\r' >file # returns xy\r: awk '/^include / {ORS=" "; print $2}' file | od

[Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-18 Thread Stefan Weil
Am 18.12.2010 00:24, schrieb Paolo Bonzini: On 12/17/2010 11:17 PM, Andreas Färber wrote: Example (needs bash's echo -e): # create line with crlf ending: echo -e 'include xy\r' >file # returns xy\r: awk '/^include / {ORS=" "; print $2}' file | od 000 074570 020015 004 # should retu

[Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-17 Thread Paolo Bonzini
On 12/17/2010 11:17 PM, Andreas Färber wrote: Example (needs bash's echo -e): # create line with crlf ending: echo -e 'include xy\r' >file # returns xy\r: awk '/^include / {ORS=" "; print $2}' file | od 000 074570 020015 004 # should return xy: awk '/^include / {ORS=" "; sub(/\r$/,

[Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-17 Thread Andreas Färber
Am 17.12.2010 um 22:25 schrieb Paolo Bonzini: On 12/17/2010 10:00 PM, Andreas Färber wrote: Am 17.12.2010 um 20:54 schrieb Stefan Weil: Am 17.12.2010 20:33, schrieb Andreas Färber: Am 17.12.2010 um 20:01 schrieb Stefan Weil: Am 17.12.2010 14:44, schrieb Paolo Bonzini: On 12/17/2010 02:34

[Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-17 Thread Paolo Bonzini
On 12/17/2010 10:00 PM, Andreas Färber wrote: Am 17.12.2010 um 20:54 schrieb Stefan Weil: Am 17.12.2010 20:33, schrieb Andreas Färber: Am 17.12.2010 um 20:01 schrieb Stefan Weil: Am 17.12.2010 14:44, schrieb Paolo Bonzini: On 12/17/2010 02:34 PM, Andreas Färber wrote: Fix this by removing

Re: [Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-17 Thread Andreas Färber
Am 17.12.2010 um 20:54 schrieb Stefan Weil: Am 17.12.2010 20:33, schrieb Andreas Färber: Am 17.12.2010 um 20:01 schrieb Stefan Weil: Am 17.12.2010 14:44, schrieb Paolo Bonzini: On 12/17/2010 02:34 PM, Andreas Färber wrote: Fix this by removing any \r at end of line. Why isn't cygwin (or

[Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-17 Thread Paolo Bonzini
On 12/17/2010 08:01 PM, Stefan Weil wrote: I currently have no possibility to run tests with other awk implementations, so I cannot tell whether \012 is needed at all (\r is not a new invention). Do all awk versions support regular expressions with characters in octal encoding?. The awk manual

Re: [Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-17 Thread Stefan Weil
Am 17.12.2010 20:33, schrieb Andreas Färber: Am 17.12.2010 um 20:01 schrieb Stefan Weil: Am 17.12.2010 14:44, schrieb Paolo Bonzini: On 12/17/2010 02:34 PM, Andreas Färber wrote: Fix this by removing any \r at end of line. Why isn't cygwin (or whatever you're using) removing it? I believ

Re: [Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-17 Thread Andreas Färber
Am 17.12.2010 um 20:01 schrieb Stefan Weil: Am 17.12.2010 14:44, schrieb Paolo Bonzini: On 12/17/2010 02:34 PM, Andreas Färber wrote: Fix this by removing any \r at end of line. Why isn't cygwin (or whatever you're using) removing it? I believe Cygwin had an option to choose the line endi

Re: [Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-17 Thread Stefan Weil
Am 17.12.2010 14:44, schrieb Paolo Bonzini: On 12/17/2010 02:34 PM, Andreas Färber wrote: Fix this by removing any \r at end of line. Why isn't cygwin (or whatever you're using) removing it? I believe Cygwin had an option to choose the line ending style once during setup. By default it uses

Re: [Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-17 Thread Paolo Bonzini
On 12/17/2010 02:34 PM, Andreas Färber wrote: Fix this by removing any \r at end of line. Why isn't cygwin (or whatever you're using) removing it? I believe Cygwin had an option to choose the line ending style once during setup. By default it uses Unix-style line endings. If someone edits so

Re: [Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-17 Thread Andreas Färber
Am 16.12.2010 um 23:42 schrieb Paolo Bonzini: On 12/16/2010 10:52 PM, Stefan Weil wrote: QEMU source code with CRLF line endings which is quite common on windows hosts fails with current make_device_config.sh. The awk script gets the name of the included file with \r, so instead of pci.mak it

[Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-16 Thread Paolo Bonzini
On 12/16/2010 10:52 PM, Stefan Weil wrote: QEMU source code with CRLF line endings which is quite common on windows hosts fails with current make_device_config.sh. The awk script gets the name of the included file with \r, so instead of pci.mak it will search for pci.mak\r which of course does n