Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 06:10:12PM +0200, Gleb Natapov wrote: > > WHQL includes surprise removal tests. So any card that passed > > that will work with surprise removal. > > > Yeah. But it is not real "surprise removal". It will not crash qemu. That was the problem I saw. That the way qxl is writ

Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 06:04:56PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 18, 2010 at 05:42:41PM +0200, Gleb Natapov wrote: > > On Thu, Nov 18, 2010 at 05:25:48PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 18, 2010 at 04:57:55PM +0200, Gleb Natapov wrote: > > > > On Thu, Nov 18, 201

Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 05:42:41PM +0200, Gleb Natapov wrote: > On Thu, Nov 18, 2010 at 05:25:48PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 18, 2010 at 04:57:55PM +0200, Gleb Natapov wrote: > > > On Thu, Nov 18, 2010 at 04:04:14PM +0200, Michael S. Tsirkin wrote: > > > > > > What do you wan

Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 05:25:48PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 18, 2010 at 04:57:55PM +0200, Gleb Natapov wrote: > > On Thu, Nov 18, 2010 at 04:04:14PM +0200, Michael S. Tsirkin wrote: > > > > > What do you want to know? > > > > How it claims access to framebuffer. Legacy VGA has

Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 04:57:55PM +0200, Gleb Natapov wrote: > On Thu, Nov 18, 2010 at 04:04:14PM +0200, Michael S. Tsirkin wrote: > > > > What do you want to know? > > > How it claims access to framebuffer. Legacy VGA has not only IO space > > > but MMIO space too. > > > > There's a separate bit

Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 04:04:14PM +0200, Michael S. Tsirkin wrote: > > > What do you want to know? > > How it claims access to framebuffer. Legacy VGA has not only IO space > > but MMIO space too. > > There's a separate bit to enable memory is that is what you > are asking about. > > The spec sp

Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 02:27:26PM +0200, Gleb Natapov wrote: > On Thu, Nov 18, 2010 at 02:03:11PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 18, 2010 at 01:55:29PM +0200, Gleb Natapov wrote: > > > On Thu, Nov 18, 2010 at 01:33:08PM +0200, Michael S. Tsirkin wrote: > > > > On Thu, Nov 18, 201

Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 02:03:11PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 18, 2010 at 01:55:29PM +0200, Gleb Natapov wrote: > > On Thu, Nov 18, 2010 at 01:33:08PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 18, 2010 at 11:57:51AM +0200, Gleb Natapov wrote: > > > > On Thu, Nov 18, 201

Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 01:55:29PM +0200, Gleb Natapov wrote: > On Thu, Nov 18, 2010 at 01:33:08PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 18, 2010 at 11:57:51AM +0200, Gleb Natapov wrote: > > > On Thu, Nov 18, 2010 at 11:30:27AM +0200, Michael S. Tsirkin wrote: > > > > On Thu, Nov 18, 201

Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 01:33:08PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 18, 2010 at 11:57:51AM +0200, Gleb Natapov wrote: > > On Thu, Nov 18, 2010 at 11:30:27AM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 18, 2010 at 11:11:49AM +0200, Gleb Natapov wrote: > > > > On Thu, Nov 18, 201

Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 11:57:51AM +0200, Gleb Natapov wrote: > On Thu, Nov 18, 2010 at 11:30:27AM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 18, 2010 at 11:11:49AM +0200, Gleb Natapov wrote: > > > On Thu, Nov 18, 2010 at 11:03:21AM +0200, Michael S. Tsirkin wrote: > > > > On Thu, Nov 18, 201

Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-18 Thread Gerd Hoffmann
Hi, I still think that vga cards should simply be flagged to be not hot-pluggable. Send a patch. [x] done. cheers, Gerd

Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 11:30:27AM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 18, 2010 at 11:11:49AM +0200, Gleb Natapov wrote: > > On Thu, Nov 18, 2010 at 11:03:21AM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 18, 2010 at 10:09:35AM +0200, Gleb Natapov wrote: > > > > On Wed, Nov 17, 201

Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 11:11:49AM +0200, Gleb Natapov wrote: > On Thu, Nov 18, 2010 at 11:03:21AM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 18, 2010 at 10:09:35AM +0200, Gleb Natapov wrote: > > > On Wed, Nov 17, 2010 at 08:00:08PM +0200, Michael S. Tsirkin wrote: > > > > > >> If so: does q

Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 11:03:21AM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 18, 2010 at 10:09:35AM +0200, Gleb Natapov wrote: > > On Wed, Nov 17, 2010 at 08:00:08PM +0200, Michael S. Tsirkin wrote: > > > > >> If so: does qemu > > > > >>emulate this correctly? > > > > > > > > > >It mostly doe

Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 09:22:02AM +0100, Gerd Hoffmann wrote: > On 11/18/10 09:09, Gleb Natapov wrote: > >On Wed, Nov 17, 2010 at 08:00:08PM +0200, Michael S. Tsirkin wrote: > > If so: does qemu > >emulate this correctly? > > It mostly does. > >>> > >>>I doubt it actually enables

Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-18 Thread Michael S. Tsirkin
On Thu, Nov 18, 2010 at 10:09:35AM +0200, Gleb Natapov wrote: > On Wed, Nov 17, 2010 at 08:00:08PM +0200, Michael S. Tsirkin wrote: > > > >> If so: does qemu > > > >>emulate this correctly? > > > > > > > >It mostly does. > > > > > > I doubt it actually enables/disables the legacy vga ports. > >

Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-18 Thread Gerd Hoffmann
On 11/18/10 09:09, Gleb Natapov wrote: On Wed, Nov 17, 2010 at 08:00:08PM +0200, Michael S. Tsirkin wrote: If so: does qemu emulate this correctly? It mostly does. I doubt it actually enables/disables the legacy vga ports. I'll check when I have the time. We can fix it if it doesn't, S

Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-18 Thread Gleb Natapov
On Wed, Nov 17, 2010 at 08:00:08PM +0200, Michael S. Tsirkin wrote: > > >> If so: does qemu > > >>emulate this correctly? > > > > > >It mostly does. > > > > I doubt it actually enables/disables the legacy vga ports. > > I'll check when I have the time. We can fix it if it doesn't, > So many gue

[Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-17 Thread Michael S. Tsirkin
On Wed, Nov 17, 2010 at 06:02:39PM +0100, Gerd Hoffmann wrote: > Hi, > > Better don't try ... > >>> > >>>Better prevent it then? > >> > >>How can I do that? > > Question still stands: Is there some way to disable hotplug for > certain pci devices? Not sure. It's really a work-around bug,

[Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-17 Thread Gerd Hoffmann
Hi, Better don't try ... Better prevent it then? How can I do that? Question still stands: Is there some way to disable hotplug for certain pci devices? How does this work btw? Only one vga adapter can drive the legacy vga ports, right? Is there some way to enable/disable this p

[Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-17 Thread Michael S. Tsirkin
On Wed, Nov 17, 2010 at 04:20:45PM +0100, Gerd Hoffmann wrote: > Hi, > > +qxl0 = qxl; > >>> > >>>What happens when this device is then removed? > >> > >>Better don't try ... > > > >Better prevent it then? > > How can I do that? > > >>The primary vga can't be hot-unplugged in qemu.

[Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-17 Thread Gerd Hoffmann
Hi, +qxl0 = qxl; What happens when this device is then removed? Better don't try ... Better prevent it then? How can I do that? The primary vga can't be hot-unplugged in qemu. Not only because the qxl0 pointer would point into nowhere in this case, but also because you can't

[Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-17 Thread Michael S. Tsirkin
On Wed, Nov 17, 2010 at 02:28:21PM +0100, Gerd Hoffmann wrote: > On 11/16/10 18:43, Michael S. Tsirkin wrote: > >On Tue, Nov 02, 2010 at 02:34:58PM +0100, Gerd Hoffmann wrote: > >>+if (ram_size< 32 * 1024 * 1024) > >>+ram_size = 32 * 1024 * 1024; > >>+vga_common_init(vg

[Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-17 Thread Gerd Hoffmann
On 11/16/10 18:43, Michael S. Tsirkin wrote: On Tue, Nov 02, 2010 at 02:34:58PM +0100, Gerd Hoffmann wrote: +if (ram_size< 32 * 1024 * 1024) +ram_size = 32 * 1024 * 1024; +vga_common_init(vga, ram_size); +vga_init(vga); +register_ioport_write(0x3c0, 1

[Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-16 Thread Michael S. Tsirkin
On Tue, Nov 02, 2010 at 02:34:58PM +0100, Gerd Hoffmann wrote: > +if (ram_size < 32 * 1024 * 1024) > +ram_size = 32 * 1024 * 1024; > +vga_common_init(vga, ram_size); > +vga_init(vga); > +register_ioport_write(0x3c0, 16, 1, qxl_vga_ioport_write, vga); > +