[Qemu-devel] Re: [PATCH] net: Remove dead code from net/socket.c

Miguel Di Ciurcio Filho wrote: > On Fri, May 14, 2010 at 2:03 PM, Jan Kiszka wrote: >>> In both cases the info_str string is written inside >>> net_socket_fd_init_(stream|dgram), and after that, it is >>> overwritten on a subsequent snprintf() in net_socket_accept(). >>> >> There is non-zero time

[Qemu-devel] Re: [PATCH] net: Remove dead code from net/socket.c

On Fri, May 14, 2010 at 2:03 PM, Jan Kiszka wrote: >> >> In both cases the info_str string is written inside >> net_socket_fd_init_(stream|dgram), and after that, it is >> overwritten on a subsequent snprintf() in net_socket_accept(). >> > > There is non-zero time window between registration and a

[Qemu-devel] Re: [PATCH] net: Remove dead code from net/socket.c

Miguel Di Ciurcio Filho wrote: > When a connection is accepted, the handler net_socket_accept() calls > net_socket_fd_init(). If the socket is UDP/multicast, > net_socket_fd_init() calls net_socket_fd_init_dgram, if > the socket is TCP it calls net_socket_fd_init_dgram_stream. > > In both cases th