Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Tue, Dec 21, 2010 at 07:13:57PM +0900, Isaku Yamahata wrote: > On Thu, Dec 16, 2010 at 10:36:08AM +0200, Michael S. Tsirkin wrote: > > On Thu, Dec 16, 2010 at 04:08:16PM +0900, Isaku Yamahata wrote: > > > On Wed, Dec 15, 2010 at 08:27:49AM -0700, Alex Williamson wrote: > > > > On Wed, 2010-12-15

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Thu, Dec 16, 2010 at 10:36:08AM +0200, Michael S. Tsirkin wrote: > On Thu, Dec 16, 2010 at 04:08:16PM +0900, Isaku Yamahata wrote: > > On Wed, Dec 15, 2010 at 08:27:49AM -0700, Alex Williamson wrote: > > > On Wed, 2010-12-15 at 11:56 +0200, Michael S. Tsirkin wrote: > > > > On Tue, Dec 14, 2010

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Thu, Dec 16, 2010 at 04:08:16PM +0900, Isaku Yamahata wrote: > On Wed, Dec 15, 2010 at 08:27:49AM -0700, Alex Williamson wrote: > > On Wed, 2010-12-15 at 11:56 +0200, Michael S. Tsirkin wrote: > > > On Tue, Dec 14, 2010 at 11:34:53AM -0700, Alex Williamson wrote: > > > > On Tue, 2010-12-14 at 14

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Wed, Dec 15, 2010 at 08:27:49AM -0700, Alex Williamson wrote: > On Wed, 2010-12-15 at 11:56 +0200, Michael S. Tsirkin wrote: > > On Tue, Dec 14, 2010 at 11:34:53AM -0700, Alex Williamson wrote: > > > On Tue, 2010-12-14 at 14:26 +0200, Michael S. Tsirkin wrote: > > > > On Mon, Dec 13, 2010 at 10:

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Wed, 2010-12-15 at 11:56 +0200, Michael S. Tsirkin wrote: > On Tue, Dec 14, 2010 at 11:34:53AM -0700, Alex Williamson wrote: > > On Tue, 2010-12-14 at 14:26 +0200, Michael S. Tsirkin wrote: > > > On Mon, Dec 13, 2010 at 10:04:24PM -0700, Alex Williamson wrote: > > > > > > > > I've only ever see

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Tue, Dec 14, 2010 at 11:34:53AM -0700, Alex Williamson wrote: > On Tue, 2010-12-14 at 14:26 +0200, Michael S. Tsirkin wrote: > > On Mon, Dec 13, 2010 at 10:04:24PM -0700, Alex Williamson wrote: > > > > > > I've only ever seen config[PCI_SECONDARY_BUS] be non-zero for an > > > assigned device, s

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Tue, 2010-12-14 at 14:26 +0200, Michael S. Tsirkin wrote: > On Mon, Dec 13, 2010 at 10:04:24PM -0700, Alex Williamson wrote: > > > > I've only ever seen config[PCI_SECONDARY_BUS] be non-zero for an > > assigned device, so I'm pretty sure we're not going to hurt migration, > > but the code is cl

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, Dec 13, 2010 at 10:04:24PM -0700, Alex Williamson wrote: > On Tue, 2010-12-14 at 06:57 +0200, Michael S. Tsirkin wrote: > > On Mon, Dec 13, 2010 at 09:49:21PM -0700, Alex Williamson wrote: > > > On Tue, 2010-12-14 at 06:46 +0200, Michael S. Tsirkin wrote: > > > > On Mon, Dec 13, 2010 at 01:

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Tue, 2010-12-14 at 06:57 +0200, Michael S. Tsirkin wrote: > On Mon, Dec 13, 2010 at 09:49:21PM -0700, Alex Williamson wrote: > > On Tue, 2010-12-14 at 06:46 +0200, Michael S. Tsirkin wrote: > > > On Mon, Dec 13, 2010 at 01:04:23PM -0700, Alex Williamson wrote: > > > > On Mon, 2010-11-08 at 13:22

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, Dec 13, 2010 at 09:49:21PM -0700, Alex Williamson wrote: > On Tue, 2010-12-14 at 06:46 +0200, Michael S. Tsirkin wrote: > > On Mon, Dec 13, 2010 at 01:04:23PM -0700, Alex Williamson wrote: > > > On Mon, 2010-11-08 at 13:22 +0200, Michael S. Tsirkin wrote: > > > > On Mon, Oct 04, 2010 at 03:

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Tue, 2010-12-14 at 06:46 +0200, Michael S. Tsirkin wrote: > On Mon, Dec 13, 2010 at 01:04:23PM -0700, Alex Williamson wrote: > > On Mon, 2010-11-08 at 13:22 +0200, Michael S. Tsirkin wrote: > > > On Mon, Oct 04, 2010 at 03:53:11PM -0600, Alex Williamson wrote: > > > > pcibus_dev_print() was erro

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, Dec 13, 2010 at 01:04:23PM -0700, Alex Williamson wrote: > On Mon, 2010-11-08 at 13:22 +0200, Michael S. Tsirkin wrote: > > On Mon, Oct 04, 2010 at 03:53:11PM -0600, Alex Williamson wrote: > > > pcibus_dev_print() was erroneously retrieving the device bus > > > number from the secondary bus

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, 2010-11-08 at 13:22 +0200, Michael S. Tsirkin wrote: > On Mon, Oct 04, 2010 at 03:53:11PM -0600, Alex Williamson wrote: > > pcibus_dev_print() was erroneously retrieving the device bus > > number from the secondary bus number offset of the device > > instead of the bridge above the device.

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, Nov 22, 2010 at 06:41:28PM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 22, 2010 at 04:58:11PM +0200, Gleb Natapov wrote: > > On Mon, Nov 22, 2010 at 04:56:16PM +0200, Michael S. Tsirkin wrote: > > > On Mon, Nov 22, 2010 at 04:52:32PM +0200, Gleb Natapov wrote: > > > > On Mon, Nov 22, 201

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, Nov 22, 2010 at 04:58:11PM +0200, Gleb Natapov wrote: > On Mon, Nov 22, 2010 at 04:56:16PM +0200, Michael S. Tsirkin wrote: > > On Mon, Nov 22, 2010 at 04:52:32PM +0200, Gleb Natapov wrote: > > > On Mon, Nov 22, 2010 at 04:50:29PM +0200, Michael S. Tsirkin wrote: > > > > On Mon, Nov 22, 201

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, Nov 22, 2010 at 04:56:16PM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 22, 2010 at 04:52:32PM +0200, Gleb Natapov wrote: > > On Mon, Nov 22, 2010 at 04:50:29PM +0200, Michael S. Tsirkin wrote: > > > On Mon, Nov 22, 2010 at 03:04:51PM +0200, Gleb Natapov wrote: > > > > On Mon, Nov 22, 201

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, Nov 22, 2010 at 04:52:32PM +0200, Gleb Natapov wrote: > On Mon, Nov 22, 2010 at 04:50:29PM +0200, Michael S. Tsirkin wrote: > > On Mon, Nov 22, 2010 at 03:04:51PM +0200, Gleb Natapov wrote: > > > On Mon, Nov 22, 2010 at 10:16:57AM +0200, Michael S. Tsirkin wrote: > > > > On Mon, Nov 22, 201

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, Nov 22, 2010 at 04:50:29PM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 22, 2010 at 03:04:51PM +0200, Gleb Natapov wrote: > > On Mon, Nov 22, 2010 at 10:16:57AM +0200, Michael S. Tsirkin wrote: > > > On Mon, Nov 22, 2010 at 09:37:07AM +0200, Gleb Natapov wrote: > > > > > > > It's probably

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, Nov 22, 2010 at 03:04:51PM +0200, Gleb Natapov wrote: > On Mon, Nov 22, 2010 at 10:16:57AM +0200, Michael S. Tsirkin wrote: > > On Mon, Nov 22, 2010 at 09:37:07AM +0200, Gleb Natapov wrote: > > > > > > It's probably required to make them stable anyway. > > > > > > > > > > > Why? > > > > >

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, Nov 22, 2010 at 10:16:57AM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 22, 2010 at 09:37:07AM +0200, Gleb Natapov wrote: > > > > > It's probably required to make them stable anyway. > > > > > > > > > Why? > > > > > > To avoid bus renumbering on reboot after you add a pci-to-pci bridge.

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, Nov 22, 2010 at 09:37:07AM +0200, Gleb Natapov wrote: > > > > It's probably required to make them stable anyway. > > > > > > > Why? > > > > To avoid bus renumbering on reboot after you add a pci-to-pci bridge. > > > Why should qemu care? Stable bus numbering is a feature *users* care ab

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Sun, Nov 21, 2010 at 10:39:31PM +0200, Michael S. Tsirkin wrote: > On Sun, Nov 21, 2010 at 09:29:59PM +0200, Gleb Natapov wrote: > > > We can control the bus numbers that the BIOS will assign to pci root. > > And if you need to insert device that sits behind pci-to-pci bridge? Do > > you want to

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Sun, Nov 21, 2010 at 09:29:59PM +0200, Gleb Natapov wrote: > > We can control the bus numbers that the BIOS will assign to pci root. > And if you need to insert device that sits behind pci-to-pci bridge? Do > you want to control that bus address too? And bus number do not unambiguously > describ

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Sun, Nov 21, 2010 at 08:22:03PM +0200, Michael S. Tsirkin wrote: > On Sun, Nov 21, 2010 at 06:01:11PM +0200, Gleb Natapov wrote: > > > This FW is given to guest by qemu. It only assigns bus numbers > > > because qemu told it to do so. > > Seabios is just a guest qemu ships. There are other FW fo

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Sun, Nov 21, 2010 at 06:01:11PM +0200, Gleb Natapov wrote: > > This FW is given to guest by qemu. It only assigns bus numbers > > because qemu told it to do so. > Seabios is just a guest qemu ships. There are other FW for qemu. We don't support them though, do we? > Bochs > bios, openfirmware,

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Sun, Nov 21, 2010 at 06:38:31PM +0200, Michael S. Tsirkin wrote: > On Sun, Nov 21, 2010 at 06:01:11PM +0200, Gleb Natapov wrote: > > On Sun, Nov 21, 2010 at 04:48:44PM +0200, Michael S. Tsirkin wrote: > > > On Sun, Nov 21, 2010 at 02:50:14PM +0200, Gleb Natapov wrote: > > > > On Sun, Nov 21, 201

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Sun, Nov 21, 2010 at 06:01:11PM +0200, Gleb Natapov wrote: > On Sun, Nov 21, 2010 at 04:48:44PM +0200, Michael S. Tsirkin wrote: > > On Sun, Nov 21, 2010 at 02:50:14PM +0200, Gleb Natapov wrote: > > > On Sun, Nov 21, 2010 at 01:53:26PM +0200, Michael S. Tsirkin wrote: > > > > > > The guests. > >

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Sun, Nov 21, 2010 at 04:48:44PM +0200, Michael S. Tsirkin wrote: > On Sun, Nov 21, 2010 at 02:50:14PM +0200, Gleb Natapov wrote: > > On Sun, Nov 21, 2010 at 01:53:26PM +0200, Michael S. Tsirkin wrote: > > > > > The guests. > > > > Which one? There are many guests. Your favorite? > > > > > > > >

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Sun, Nov 21, 2010 at 02:50:14PM +0200, Gleb Natapov wrote: > On Sun, Nov 21, 2010 at 01:53:26PM +0200, Michael S. Tsirkin wrote: > > > > The guests. > > > Which one? There are many guests. Your favorite? > > > > > > > For CLI, we need an easy way to map a device in guest to the > > > > device i

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Sun, Nov 21, 2010 at 01:53:26PM +0200, Michael S. Tsirkin wrote: > > > The guests. > > Which one? There are many guests. Your favorite? > > > > > For CLI, we need an easy way to map a device in guest to the > > > device in qemu and back. > > Then use eth0, /dev/sdb, or even C:. Your way is not

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Sun, Nov 21, 2010 at 12:19:03PM +0200, Gleb Natapov wrote: > On Sun, Nov 21, 2010 at 11:50:18AM +0200, Michael S. Tsirkin wrote: > > On Sun, Nov 21, 2010 at 10:32:11AM +0200, Gleb Natapov wrote: > > > On Sat, Nov 20, 2010 at 10:17:09PM +0200, Michael S. Tsirkin wrote: > > > > On Fri, Nov 19, 201

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Sun, Nov 21, 2010 at 11:50:18AM +0200, Michael S. Tsirkin wrote: > On Sun, Nov 21, 2010 at 10:32:11AM +0200, Gleb Natapov wrote: > > On Sat, Nov 20, 2010 at 10:17:09PM +0200, Michael S. Tsirkin wrote: > > > On Fri, Nov 19, 2010 at 10:38:42PM +0200, Gleb Natapov wrote: > > > > On Fri, Nov 19, 201

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Sun, Nov 21, 2010 at 10:32:11AM +0200, Gleb Natapov wrote: > On Sat, Nov 20, 2010 at 10:17:09PM +0200, Michael S. Tsirkin wrote: > > On Fri, Nov 19, 2010 at 10:38:42PM +0200, Gleb Natapov wrote: > > > On Fri, Nov 19, 2010 at 06:02:58PM +0100, Markus Armbruster wrote: > > > > "Michael S. Tsirkin"

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Sat, Nov 20, 2010 at 10:17:09PM +0200, Michael S. Tsirkin wrote: > On Fri, Nov 19, 2010 at 10:38:42PM +0200, Gleb Natapov wrote: > > On Fri, Nov 19, 2010 at 06:02:58PM +0100, Markus Armbruster wrote: > > > "Michael S. Tsirkin" writes: > > > > > > > On Tue, Nov 09, 2010 at 11:41:43AM +0900, Isa

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Fri, Nov 19, 2010 at 10:38:42PM +0200, Gleb Natapov wrote: > On Fri, Nov 19, 2010 at 06:02:58PM +0100, Markus Armbruster wrote: > > "Michael S. Tsirkin" writes: > > > > > On Tue, Nov 09, 2010 at 11:41:43AM +0900, Isaku Yamahata wrote: > > >> On Mon, Nov 08, 2010 at 06:26:33PM +0200, Michael S.

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Fri, Nov 19, 2010 at 06:02:58PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Tue, Nov 09, 2010 at 11:41:43AM +0900, Isaku Yamahata wrote: > >> On Mon, Nov 08, 2010 at 06:26:33PM +0200, Michael S. Tsirkin wrote: > >> > Replace bus number with slot numbers of parent br

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

"Michael S. Tsirkin" writes: > On Tue, Nov 09, 2010 at 11:41:43AM +0900, Isaku Yamahata wrote: >> On Mon, Nov 08, 2010 at 06:26:33PM +0200, Michael S. Tsirkin wrote: >> > Replace bus number with slot numbers of parent bridges up to the root. >> > This works for root bridge in a compatible way bec

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Tue, Nov 09, 2010 at 11:41:43AM +0900, Isaku Yamahata wrote: > On Mon, Nov 08, 2010 at 06:26:33PM +0200, Michael S. Tsirkin wrote: > > Replace bus number with slot numbers of parent bridges up to the root. > > This works for root bridge in a compatible way because bus number there > > is hard-co

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, Nov 08, 2010 at 06:26:33PM +0200, Michael S. Tsirkin wrote: > Replace bus number with slot numbers of parent bridges up to the root. > This works for root bridge in a compatible way because bus number there > is hard-coded to 0. > IMO nested bridges are broken anyway, no way to be compatibl

[Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, Nov 08, 2010 at 07:08:37PM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2010 at 07:00:15PM +0200, Gleb Natapov wrote: > > On Mon, Nov 08, 2010 at 06:26:33PM +0200, Michael S. Tsirkin wrote: > > > On Mon, Nov 08, 2010 at 07:52:12AM -0700, Alex Williamson wrote: > > > > On Mon, 2010-11-

[Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, Nov 08, 2010 at 07:00:15PM +0200, Gleb Natapov wrote: > On Mon, Nov 08, 2010 at 06:26:33PM +0200, Michael S. Tsirkin wrote: > > On Mon, Nov 08, 2010 at 07:52:12AM -0700, Alex Williamson wrote: > > > On Mon, 2010-11-08 at 13:22 +0200, Michael S. Tsirkin wrote: > > > > On Mon, Oct 04, 2010 at

[Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, Nov 08, 2010 at 06:26:33PM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2010 at 07:52:12AM -0700, Alex Williamson wrote: > > On Mon, 2010-11-08 at 13:22 +0200, Michael S. Tsirkin wrote: > > > On Mon, Oct 04, 2010 at 03:53:11PM -0600, Alex Williamson wrote: > > > > pcibus_dev_print() w

[Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, Nov 08, 2010 at 09:36:59AM -0700, Alex Williamson wrote: > On Mon, 2010-11-08 at 18:26 +0200, Michael S. Tsirkin wrote: > > On Mon, Nov 08, 2010 at 07:52:12AM -0700, Alex Williamson wrote: > > > On Mon, 2010-11-08 at 13:22 +0200, Michael S. Tsirkin wrote: > > > > On Mon, Oct 04, 2010 at 03:

[Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, 2010-11-08 at 18:26 +0200, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2010 at 07:52:12AM -0700, Alex Williamson wrote: > > On Mon, 2010-11-08 at 13:22 +0200, Michael S. Tsirkin wrote: > > > On Mon, Oct 04, 2010 at 03:53:11PM -0600, Alex Williamson wrote: > > > > pcibus_dev_print() was erro

[Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, Nov 08, 2010 at 07:52:12AM -0700, Alex Williamson wrote: > On Mon, 2010-11-08 at 13:22 +0200, Michael S. Tsirkin wrote: > > On Mon, Oct 04, 2010 at 03:53:11PM -0600, Alex Williamson wrote: > > > pcibus_dev_print() was erroneously retrieving the device bus > > > number from the secondary bus

[Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, 2010-11-08 at 13:22 +0200, Michael S. Tsirkin wrote: > On Mon, Oct 04, 2010 at 03:53:11PM -0600, Alex Williamson wrote: > > pcibus_dev_print() was erroneously retrieving the device bus > > number from the secondary bus number offset of the device > > instead of the bridge above the device.

[Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

On Mon, Oct 04, 2010 at 03:53:11PM -0600, Alex Williamson wrote: > pcibus_dev_print() was erroneously retrieving the device bus > number from the secondary bus number offset of the device > instead of the bridge above the device. This ends of landing > in the 2nd byte of the 3rd BAR for devices, w