[Qemu-devel] Re: [PATCH] A bit optimization for tlb_set_page() (resend)

2010-05-08 Thread Jan Kiszka
Jun Koi wrote: > This patch avoids handling write watchpoints on read-only memory access. > It also breaks the searching loop for watchpoint once the setup for > handling watchpoint later is done. > > Signed-off-by: Jun Koi > Works fine. Acked-by: Jan Kiszka > > diff --git a/exec.c b/exec.c

[Qemu-devel] Re: [PATCH] A bit optimization for tlb_set_page()

2010-04-29 Thread Jan Kiszka
Jun Koi wrote: > On Wed, Apr 28, 2010 at 3:53 PM, Jan Kiszka wrote: >> Jun Koi wrote: >>> On Wed, Apr 28, 2010 at 8:48 AM, Jun Koi wrote: On Wed, Apr 28, 2010 at 3:36 AM, Jan Kiszka wrote: > Jun Koi wrote: >> It is not necessary to continue searching for watchpoint when we >> al

[Qemu-devel] Re: [PATCH] A bit optimization for tlb_set_page()

2010-04-28 Thread Jun Koi
On Wed, Apr 28, 2010 at 3:53 PM, Jan Kiszka wrote: > Jun Koi wrote: >> On Wed, Apr 28, 2010 at 8:48 AM, Jun Koi wrote: >>> On Wed, Apr 28, 2010 at 3:36 AM, Jan Kiszka wrote: Jun Koi wrote: > It is not necessary to continue searching for watchpoint when we > already found one and set

[Qemu-devel] Re: [PATCH] A bit optimization for tlb_set_page()

2010-04-27 Thread Jan Kiszka
Jun Koi wrote: > On Wed, Apr 28, 2010 at 8:48 AM, Jun Koi wrote: >> On Wed, Apr 28, 2010 at 3:36 AM, Jan Kiszka wrote: >>> Jun Koi wrote: It is not necessary to continue searching for watchpoint when we already found one and setup for handling watchpoint in a search loop in tlb_set

[Qemu-devel] Re: [PATCH] A bit optimization for tlb_set_page()

2010-04-27 Thread Jun Koi
On Wed, Apr 28, 2010 at 8:48 AM, Jun Koi wrote: > On Wed, Apr 28, 2010 at 3:36 AM, Jan Kiszka wrote: >> Jun Koi wrote: >>> It is not necessary to continue searching for watchpoint when we >>> already found one and setup for handling watchpoint in a search loop >>> in tlb_set_page(). >>> This patc

[Qemu-devel] Re: [PATCH] A bit optimization for tlb_set_page()

2010-04-27 Thread Jun Koi
On Wed, Apr 28, 2010 at 3:36 AM, Jan Kiszka wrote: > Jun Koi wrote: >> It is not necessary to continue searching for watchpoint when we >> already found one and setup for handling watchpoint in a search loop >> in tlb_set_page(). >> This patch breaks that search loop on then. > > Acked-by: Jan Kis

[Qemu-devel] Re: [PATCH] A bit optimization for tlb_set_page()

2010-04-27 Thread Jan Kiszka
Jun Koi wrote: > It is not necessary to continue searching for watchpoint when we > already found one and setup for handling watchpoint in a search loop > in tlb_set_page(). > This patch breaks that search loop on then. Acked-by: Jan Kiszka > > Signed-off-by: Jun Koi > > diff --git a/exec.c b