I am glad to have an accurate sync bdrv_flush(). Code looks fine.
Reviewed-by: Wenchao Xia
> This patch makes bdrv_flush a synchronous function and updates any callers
> from
> a coroutine context to use bdrv_co_flush instead.
>
> The motivation for this patch comes from the GSoC Continuatio
On Tue, Jul 23, 2013 at 03:36:28PM +0200, Stefan Hajnoczi wrote:
> On Tue, Jul 23, 2013 at 01:10:35PM +0100, Gabriel Kerneis wrote:
> > On Tue, Jul 23, 2013 at 02:05:15PM +0200, Stefan Hajnoczi wrote:
> > > A built-time check for coroutine_fn would be valuable if we ever hope to
> > > get disciplin
On Tue, Jul 23, 2013 at 01:10:35PM +0100, Gabriel Kerneis wrote:
> On Tue, Jul 23, 2013 at 02:05:15PM +0200, Stefan Hajnoczi wrote:
> > A built-time check for coroutine_fn would be valuable if we ever hope to
> > get disciplined with this annotation.
> >
> > The check can detect when a coroutine_f
On Tue, Jul 23, 2013 at 02:05:15PM +0200, Stefan Hajnoczi wrote:
> A built-time check for coroutine_fn would be valuable if we ever hope to
> get disciplined with this annotation.
>
> The check can detect when a coroutine_fn is invoked outside coroutine
> context. I wonder if Coccinelle can detec
On Fri, Jul 19, 2013 at 10:37:11AM +0200, Kevin Wolf wrote:
> Am 19.07.2013 um 07:27 hat Stefan Hajnoczi geschrieben:
> > On Thu, Jul 18, 2013 at 11:21:42PM +0200, Charlie Shepherd wrote:
> > > This patch makes bdrv_flush a synchronous function and updates any
> > > callers from
> > > a coroutine
Am 19.07.2013 um 07:27 hat Stefan Hajnoczi geschrieben:
> On Thu, Jul 18, 2013 at 11:21:42PM +0200, Charlie Shepherd wrote:
> > This patch makes bdrv_flush a synchronous function and updates any callers
> > from
> > a coroutine context to use bdrv_co_flush instead.
> >
> > The motivation for this
On Thu, Jul 18, 2013 at 11:21:42PM +0200, Charlie Shepherd wrote:
> This patch makes bdrv_flush a synchronous function and updates any callers
> from
> a coroutine context to use bdrv_co_flush instead.
>
> The motivation for this patch comes from the GSoC Continuation-Passing C
> project. When co
This patch makes bdrv_flush a synchronous function and updates any callers from
a coroutine context to use bdrv_co_flush instead.
The motivation for this patch comes from the GSoC Continuation-Passing C
project. When coroutines were introduced, synchronous functions in the block
layer were convert
