Re: [Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy

2012-03-24 Thread Christoph Hellwig
On Fri, Mar 09, 2012 at 06:16:54PM +0100, Paolo Bonzini wrote: > > I'm wondering whether it's worth expanding the SELinux policy if we > > will have no fstatfs(2) callers in QEMU. Are you planning to drop the > > XFS code? > > Chris Wedgwood said that on XFS you want to do discard even if the fil

Re: [Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy

2012-03-24 Thread Christoph Hellwig
On Fri, Mar 09, 2012 at 04:07:43PM +, Stefan Hajnoczi wrote: > Paolo, your discard improvements in QEMU add FALLOC_FL_PUNCH_HOLE > support. XFS supports this fallocate() flag in current kernels, > thereby making the XFS-specific support obsolete. > > I'm wondering whether it's worth expanding

Re: [Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy

2012-03-09 Thread Stefan Hajnoczi
On Fri, Mar 9, 2012 at 5:16 PM, Paolo Bonzini wrote: > Il 09/03/2012 17:07, Stefan Hajnoczi ha scritto: >>> > So am I correct that this extra permission is only needed for a single >>> > RHEL6 release? If qemu won't be doing fstafs on an ongoing basis, it >>> > doesn't seem like a good idea to per

Re: [Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 17:07, Stefan Hajnoczi ha scritto: >> > So am I correct that this extra permission is only needed for a single >> > RHEL6 release? If qemu won't be doing fstafs on an ongoing basis, it >> > doesn't seem like a good idea to permanently open up the permissions >> > allowed by virt_use_n

Re: [Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy

2012-03-09 Thread Daniel P. Berrange
On Fri, Mar 09, 2012 at 11:32:47AM +, Stefan Hajnoczi wrote: > Hi, > I have a question about the libvirt SELinux policy that can be applied > to QEMU processes. Yesterday Laine helped Khoa and me diagnose an > issue where QEMU was doing fstatfs(2) but SELinux prevented this > FILESYSTEM__GETAT

Re: [Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy

2012-03-09 Thread Stefan Hajnoczi
On Fri, Mar 9, 2012 at 3:11 PM, Laine Stump wrote: > On 03/09/2012 09:16 AM, Jiri Denemark wrote: >> Hi. >> >> On Fri, Mar 09, 2012 at 11:32:47 +, Stefan Hajnoczi wrote: >> ... >>> static __inline__ int platform_test_xfs_fd(int fd) >>> { >>>         struct statfs buf; >>>         if (fstatfs(f

Re: [Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy

2012-03-09 Thread George Wilson
Hi Stefan, The SELinux policy may need to be updated to accommodate the access. Following is a summary of the general procedure in practical terms for handling simple issues with existing policy like the one you describe (other more complex problems would likely require additional actions). Look

Re: [Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy

2012-03-09 Thread Stefan Hajnoczi
On Fri, Mar 9, 2012 at 3:11 PM, Laine Stump wrote: > On 03/09/2012 09:16 AM, Jiri Denemark wrote: >> Hi. >> >> On Fri, Mar 09, 2012 at 11:32:47 +, Stefan Hajnoczi wrote: >> ... >>> static __inline__ int platform_test_xfs_fd(int fd) >>> { >>>         struct statfs buf; >>>         if (fstatfs(f

Re: [Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy

2012-03-09 Thread Laine Stump
On 03/09/2012 09:16 AM, Jiri Denemark wrote: > Hi. > > On Fri, Mar 09, 2012 at 11:32:47 +, Stefan Hajnoczi wrote: > ... >> static __inline__ int platform_test_xfs_fd(int fd) >> { >> struct statfs buf; >> if (fstatfs(fd, &buf) < 0) >> return 0; >> return (

Re: [Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy

2012-03-09 Thread Jiri Denemark
Hi. On Fri, Mar 09, 2012 at 11:32:47 +, Stefan Hajnoczi wrote: ... > static __inline__ int platform_test_xfs_fd(int fd) > { > struct statfs buf; > if (fstatfs(fd, &buf) < 0) > return 0; > return (buf.f_type == 0x58465342); /* XFSB */ > } > > In oth

[Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy

2012-03-09 Thread Stefan Hajnoczi
Hi, I have a question about the libvirt SELinux policy that can be applied to QEMU processes. Yesterday Laine helped Khoa and me diagnose an issue where QEMU was doing fstatfs(2) but SELinux prevented this FILESYSTEM__GETATTR operation, resulting in a failed syscall with -EACCES. The SELinux hook