Re: [Qemu-devel] Please read: make check framework

2012-01-11 Thread Kevin Wolf
Am 10.01.2012 00:56, schrieb Anthony Liguori: > On 01/09/2012 05:22 PM, Andreas Färber wrote: >> Am 09.01.2012 22:42, schrieb Anthony Liguori: >>> If there's some piece of QEMU you care about, start writing tests and >>> tie it into make check. It's that simple :-) >> >> Not quite. It would be eas

Re: [Qemu-devel] Please read: make check framework

2012-01-11 Thread Anthony Liguori
On 01/10/2012 03:57 AM, Kevin Wolf wrote: Am 10.01.2012 00:56, schrieb Anthony Liguori: On 01/09/2012 05:22 PM, Andreas Färber wrote: Am 09.01.2012 22:42, schrieb Anthony Liguori: If there's some piece of QEMU you care about, start writing tests and tie it into make check. It's that simple :-

Re: [Qemu-devel] Please read: make check framework

2012-01-11 Thread Luiz Capitulino
On Tue, 10 Jan 2012 08:39:07 + Stefan Hajnoczi wrote: > On Mon, Jan 09, 2012 at 10:04:38AM -0600, Anthony Liguori wrote: > > The general rules for 'make check-quick': > > > > 1) It must complete in less than 10 minutes start to finish (the > > entire rule). We can re-examine this over time

Re: [Qemu-devel] Please read: make check framework

2012-01-11 Thread Stefan Hajnoczi
On Mon, Jan 09, 2012 at 10:04:38AM -0600, Anthony Liguori wrote: > The general rules for 'make check-quick': > > 1) It must complete in less than 10 minutes start to finish (the > entire rule). We can re-examine this over time but for now, it > seems like a reasonable limit. > > 2) It must gra

Re: [Qemu-devel] Please read: make check framework

2012-01-11 Thread Peter Maydell
On 10 January 2012 14:49, Andreas Färber wrote: > Haven't checked the kernel for Cortex-R4F support yet but my board > doesn't really support it memory-wise (unless there's sufficient RAM to > boot via CAN, but point is, not all boards are manufactured for Linux). Also R profile doesn't have an M

Re: [Qemu-devel] Please read: make check framework

2012-01-11 Thread Andreas Färber
Am 10.01.2012 00:56, schrieb Anthony Liguori: > On 01/09/2012 05:22 PM, Andreas Färber wrote: >> Am 09.01.2012 22:42, schrieb Anthony Liguori: >>> On 01/09/2012 02:57 PM, Andreas Färber wrote: Am 09.01.2012 20:28, schrieb Anthony Liguori: > We're still short on infrastructure right now so

Re: [Qemu-devel] Please read: make check framework

2012-01-10 Thread Anthony Liguori
On 01/09/2012 05:22 PM, Andreas Färber wrote: Am 09.01.2012 22:42, schrieb Anthony Liguori: On 01/09/2012 02:57 PM, Andreas Färber wrote: Am 09.01.2012 20:28, schrieb Anthony Liguori: We're still short on infrastructure right now so I expect that a lot of stuff will get merged without tests at

Re: [Qemu-devel] Please read: make check framework

2012-01-10 Thread Andreas Färber
Am 09.01.2012 20:28, schrieb Anthony Liguori: > On 01/09/2012 11:47 AM, Paul Brook wrote: >> - What level of testing is appropriate? As a maintainer when can/should I >> bounce a patch due to lack of tests? > > Yes. Note the "when". :) >> e.g should new device emulation come with >> unit tests?

Re: [Qemu-devel] Please read: make check framework

2012-01-10 Thread Andreas Färber
Am 09.01.2012 22:42, schrieb Anthony Liguori: > On 01/09/2012 02:57 PM, Andreas Färber wrote: >> Am 09.01.2012 20:28, schrieb Anthony Liguori: >>> We're still short on infrastructure right now so I expect that a lot of >>> stuff will get merged without tests at first. As we get more test >>> infra

Re: [Qemu-devel] Please read: make check framework

2012-01-10 Thread Stefan Weil
Am 09.01.2012 17:04, schrieb Anthony Liguori: Hi, I'm going to apply this series quickly and will start running 'make check-quick' as part a sniff test before pushing patches. I'd like to request that all maintainers/submaintainers do the same and that everyone contributes unit tests to this

Re: [Qemu-devel] Please read: make check framework

2012-01-10 Thread Anthony Liguori
On 01/09/2012 02:57 PM, Andreas Färber wrote: Am 09.01.2012 20:28, schrieb Anthony Liguori: On 01/09/2012 11:47 AM, Paul Brook wrote: - What level of testing is appropriate? As a maintainer when can/should I bounce a patch due to lack of tests? Yes. Note the "when". :) I read "should". I

Re: [Qemu-devel] Please read: make check framework

2012-01-09 Thread Avi Kivity
On 01/09/2012 06:04 PM, Anthony Liguori wrote: > Hi, > > I'm going to apply this series quickly and will start running 'make > check-quick' as part a sniff test before pushing patches. > > I'd like to request that all maintainers/submaintainers do the same > and that everyone contributes unit tests

Re: [Qemu-devel] Please read: make check framework

2012-01-09 Thread Anthony Liguori
On 01/09/2012 11:47 AM, Paul Brook wrote: I'm going to apply this series quickly and will start running 'make check-quick' as part a sniff test before pushing patches. I'd like to request that all maintainers/submaintainers do the same and that everyone contributes unit tests to this target. Th

Re: [Qemu-devel] Please read: make check framework

2012-01-09 Thread Anthony Liguori
On 01/09/2012 10:16 AM, Avi Kivity wrote: On 01/09/2012 06:04 PM, Anthony Liguori wrote: Hi, I'm going to apply this series quickly and will start running 'make check-quick' as part a sniff test before pushing patches. I'd like to request that all maintainers/submaintainers do the same and tha

Re: [Qemu-devel] Please read: make check framework

2012-01-09 Thread Daniel Gollub
Hi Anthony, On Monday, January 09, 2012 05:04:38 PM Anthony Liguori wrote: [...] > It would also be nice to get this integrated as part of buildbot. > Stefan/Daniel, is that something we can do? Sure, that is pretty easy modification for the current buildbot environment we just need to add: f_

Re: [Qemu-devel] Please read: make check framework

2012-01-09 Thread Paul Brook
> I'm going to apply this series quickly and will start running 'make > check-quick' as part a sniff test before pushing patches. > > I'd like to request that all maintainers/submaintainers do the same and > that everyone contributes unit tests to this target. > > The general rules for 'make chec