Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-04-11 Thread Paolo Bonzini
Il 26/03/2012 18:01, Anthony Liguori ha scritto: > On 03/26/2012 10:59 AM, Kevin Wolf wrote: >> Am 26.03.2012 17:38, schrieb Anthony Liguori: >>> You can add parameters to Errors in a fully compatible fashion, so >>> just add an >>> filename parameter to PermissionDenied. Problem solved. >> >> So

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Anthony Liguori
On 03/26/2012 10:59 AM, Kevin Wolf wrote: Am 26.03.2012 17:38, schrieb Anthony Liguori: You can add parameters to Errors in a fully compatible fashion, so just add an filename parameter to PermissionDenied. Problem solved. So your error types will end up accumulating optional parameters for a

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Kevin Wolf
Am 26.03.2012 17:38, schrieb Anthony Liguori: > On 03/26/2012 10:34 AM, Kevin Wolf wrote: >> Am 26.03.2012 17:14, schrieb Anthony Liguori: >>> On 03/26/2012 10:08 AM, Kevin Wolf wrote: Am 26.03.2012 15:37, schrieb Anthony Liguori: > On 03/26/2012 03:39 AM, Kevin Wolf wrote: >> Hi,

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Anthony Liguori
On 03/26/2012 10:34 AM, Kevin Wolf wrote: Am 26.03.2012 17:14, schrieb Anthony Liguori: On 03/26/2012 10:08 AM, Kevin Wolf wrote: Am 26.03.2012 15:37, schrieb Anthony Liguori: On 03/26/2012 03:39 AM, Kevin Wolf wrote: Hi, I keep getting reports of problems, with nice error descriptions that

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Kevin Wolf
Am 26.03.2012 17:14, schrieb Anthony Liguori: > On 03/26/2012 10:08 AM, Kevin Wolf wrote: >> Am 26.03.2012 15:37, schrieb Anthony Liguori: >>> On 03/26/2012 03:39 AM, Kevin Wolf wrote: Hi, I keep getting reports of problems, with nice error descriptions that usually look very si

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Kevin Wolf
Am 26.03.2012 16:54, schrieb Luiz Capitulino: > On Mon, 26 Mar 2012 16:47:51 +0200 > Kevin Wolf wrote: > >> Am 26.03.2012 16:33, schrieb Luiz Capitulino: >>> On Mon, 26 Mar 2012 16:04:26 +0200 >>> Kevin Wolf wrote: >>> >> Does the patch that you mentioned add a generic way for adding an

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Anthony Liguori
On 03/26/2012 10:08 AM, Kevin Wolf wrote: Am 26.03.2012 15:37, schrieb Anthony Liguori: On 03/26/2012 03:39 AM, Kevin Wolf wrote: Hi, I keep getting reports of problems, with nice error descriptions that usually look very similar to what I produced here: {"execute":"blockdev-snapshot-sync","a

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Kevin Wolf
Am 26.03.2012 15:37, schrieb Anthony Liguori: > On 03/26/2012 03:39 AM, Kevin Wolf wrote: >> Hi, >> >> I keep getting reports of problems, with nice error descriptions that >> usually look very similar to what I produced here: >> >> {"execute":"blockdev-snapshot-sync","arguments":{"device":"ide0-hd

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Luiz Capitulino
On Mon, 26 Mar 2012 16:47:51 +0200 Kevin Wolf wrote: > Am 26.03.2012 16:33, schrieb Luiz Capitulino: > > On Mon, 26 Mar 2012 16:04:26 +0200 > > Kevin Wolf wrote: > > > Does the patch that you mentioned add a generic way for adding an > (converted) errno to QMP errors? Or does it split

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Kevin Wolf
Am 26.03.2012 16:33, schrieb Luiz Capitulino: > On Mon, 26 Mar 2012 16:04:26 +0200 > Kevin Wolf wrote: > Does the patch that you mentioned add a generic way for adding an (converted) errno to QMP errors? Or does it split up existing errors into more and finer grained errors? >>> >>

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Luiz Capitulino
On Mon, 26 Mar 2012 16:04:26 +0200 Kevin Wolf wrote: > >> Does the patch that you mentioned add a generic way for adding an > >> (converted) errno to QMP errors? Or does it split up existing errors > >> into more and finer grained errors? > > > > The latter. The QMP errors have to be added manua

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Kevin Wolf
Am 26.03.2012 15:28, schrieb Luiz Capitulino: > On Mon, 26 Mar 2012 15:13:36 +0200 > Kevin Wolf wrote: > >> Am 26.03.2012 14:46, schrieb Luiz Capitulino: >>> On Mon, 26 Mar 2012 10:39:50 +0200 >>> Kevin Wolf wrote: >>> Hi, I keep getting reports of problems, with nice error descri

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Anthony Liguori
On 03/26/2012 08:28 AM, Luiz Capitulino wrote: On Mon, 26 Mar 2012 15:13:36 +0200 Kevin Wolf wrote: Am 26.03.2012 14:46, schrieb Luiz Capitulino: On Mon, 26 Mar 2012 10:39:50 +0200 Kevin Wolf wrote: Hi, I keep getting reports of problems, with nice error descriptions that usually look ver

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Anthony Liguori
On 03/26/2012 03:39 AM, Kevin Wolf wrote: Hi, I keep getting reports of problems, with nice error descriptions that usually look very similar to what I produced here: {"execute":"blockdev-snapshot-sync","arguments":{"device":"ide0-hd0","snapshot-file":"/tmp/backing.qcow2"}} {"error": {"class":

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Luiz Capitulino
On Mon, 26 Mar 2012 15:13:36 +0200 Kevin Wolf wrote: > Am 26.03.2012 14:46, schrieb Luiz Capitulino: > > On Mon, 26 Mar 2012 10:39:50 +0200 > > Kevin Wolf wrote: > > > >> Hi, > >> > >> I keep getting reports of problems, with nice error descriptions that > >> usually look very similar to what I

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Kevin Wolf
Am 26.03.2012 14:46, schrieb Luiz Capitulino: > On Mon, 26 Mar 2012 10:39:50 +0200 > Kevin Wolf wrote: > >> Hi, >> >> I keep getting reports of problems, with nice error descriptions that >> usually look very similar to what I produced here: >> >> {"execute":"blockdev-snapshot-sync","arguments":{

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Luiz Capitulino
On Mon, 26 Mar 2012 10:39:50 +0200 Kevin Wolf wrote: > Hi, > > I keep getting reports of problems, with nice error descriptions that > usually look very similar to what I produced here: > > {"execute":"blockdev-snapshot-sync","arguments":{"device":"ide0-hd0","snapshot-file":"/tmp/backing.qcow2"

[Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Kevin Wolf
Hi, I keep getting reports of problems, with nice error descriptions that usually look very similar to what I produced here: {"execute":"blockdev-snapshot-sync","arguments":{"device":"ide0-hd0","snapshot-file":"/tmp/backing.qcow2"}} {"error": {"class": "OpenFileFailed", "desc": "Could not open '/