Re: [Qemu-devel] Fwd: qemu code review

2009-11-23 Thread Daniel P. Berrange
On Thu, Nov 19, 2009 at 01:11:56PM -0500, Steve Grubb wrote: > On Thursday 19 November 2009 04:09:48 am Kevin Wolf wrote: > > >> ... > > >> In hw/e1000.c at line 89, vlan is declared to be 4 bytes. At line 382 is > > >> an attempt to do a memmove over it with a size of 12. > > > > > > Obviously thi

Re: [Qemu-devel] Fwd: qemu code review

2009-11-21 Thread Steve Grubb
On Thursday 19 November 2009 04:09:48 am Kevin Wolf wrote: > >> ... > >> In hw/e1000.c at line 89, vlan is declared to be 4 bytes. At line 382 is > >> an attempt to do a memmove over it with a size of 12. > > > > Obviously this was intentional. Would replacing > > memmove(tp->vlan, tp->data

Re: [Qemu-devel] Fwd: qemu code review

2009-11-19 Thread Kevin Wolf
Am 18.11.2009 20:06, schrieb Stefan Weil: > Kevin Wolf schrieb: >> Hi all, >> >> as Steve suggests, I'm forwarding the list of issues he found to the >> mailing list. I've already looked at a few points in the block code and >> sent patches. If everyone picks up one point, we should get through the

Re: [Qemu-devel] Fwd: qemu code review

2009-11-18 Thread Stefan Weil
Kevin Wolf schrieb: > Hi all, > > as Steve suggests, I'm forwarding the list of issues he found to the > mailing list. I've already looked at a few points in the block code and > sent patches. If everyone picks up one point, we should get through the > list quickly. Who volunteers for the TCG ones?

Re: [Qemu-devel] Fwd: qemu code review

2009-11-18 Thread Blue Swirl
On Wed, Nov 18, 2009 at 1:39 PM, Kevin Wolf wrote: > Hi all, > > as Steve suggests, I'm forwarding the list of issues he found to the > mailing list. I've already looked at a few points in the block code and > sent patches. If everyone picks up one point, we should get through the > list quickly.

Re: [Qemu-devel] Fwd: qemu code review

2009-11-18 Thread malc
On Wed, 18 Nov 2009, Kevin Wolf wrote: > Hi all, > > as Steve suggests, I'm forwarding the list of issues he found to the > mailing list. I've already looked at a few points in the block code and > sent patches. If everyone picks up one point, we should get through the > list quickly. Who volunte

[Qemu-devel] Fwd: qemu code review

2009-11-18 Thread Kevin Wolf
Hi all, as Steve suggests, I'm forwarding the list of issues he found to the mailing list. I've already looked at a few points in the block code and sent patches. If everyone picks up one point, we should get through the list quickly. Who volunteers for the TCG ones? ;-) Kevin Original-