Re: [Qemu-devel] Discussion: vnc: memory leak in zrle_compress_data

2019-09-19 Thread Li Qiang
Gerd Hoffmann 于2019年9月19日周四 下午4:54写道: > On Sun, Sep 01, 2019 at 10:43:42PM +0800, Li Qiang wrote: > > fangying 于2019年9月1日周日 下午8:29写道: > > > > > Nice work, your patch does fix this issue in my test. > > > > > > I think we should make VncState.zlib to be a pointer type as well. > > > > > > Since w

Re: [Qemu-devel] Discussion: vnc: memory leak in zrle_compress_data

2019-09-19 Thread Gerd Hoffmann
On Sun, Sep 01, 2019 at 10:43:42PM +0800, Li Qiang wrote: > fangying 于2019年9月1日周日 下午8:29写道: > > > Nice work, your patch does fix this issue in my test. > > > > I think we should make VncState.zlib to be a pointer type as well. > > > > Since we are going to use pointers instead of copy, we must ma

Re: [Qemu-devel] Discussion: vnc: memory leak in zrle_compress_data

2019-09-01 Thread Li Qiang
a better way than using pointer before sending the revision. Thanks, Li Qiang > > Thanks. > Ying Fang > *发件人: *Li Qiang > *收件人: *fangying > *抄送: *Gerd > Hoffmann;qemu-devel;Daniel > P. Berrange;zhouyibo > *主题: *Re: [Qemu-devel] Discussion: vnc: memory leak in zrle_compr

Re: [Qemu-devel] Discussion: vnc: memory leak in zrle_compress_data

2019-09-01 Thread fangying
:zhouyi...@huawei.com>> 主题: Re: [Qemu-devel] Discussion: vnc: memory leak in zrle_compress_data 时间: 2019-08-31 23:48:10 fangying mailto:fangyi...@huawei.com>> 于2019年8月31日周六 上午8:45写道: Hi Gerd, Memory leak is observed in zrle_compress_data when we are doing some AddressSa

Re: [Qemu-devel] Discussion: vnc: memory leak in zrle_compress_data

2019-08-31 Thread Li Qiang
fangying 于2019年8月31日周六 上午8:45写道: > Hi Gerd, > > Memory leak is observed in zrle_compress_data when we are doing some > AddressSanitizer tests. The leak stack is as bellow: > > = > ==47887==ERROR: LeakSanitizer: detected memory leaks

[Qemu-devel] Discussion: vnc: memory leak in zrle_compress_data

2019-08-30 Thread fangying
Hi Gerd, Memory leak is observed in zrle_compress_data when we are doing some AddressSanitizer tests. The leak stack is as bellow: = ==47887==ERROR: LeakSanitizer: detected memory leaks Direct leak of 29760 byte(s) in 5 object(s)