Re: [Qemu-devel] Correction needed for R5900 instruction decoding

2018-11-02 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 1/11/18 12:06, Aleksandar Markovic wrote: Hi, Fridrik, I did some closer code inspection of R5900 in last few days, and I noticed some sub-optimal implementation in the area where R5900-specific opcodes overlap with the rest-of-MIPS-CPUs opcodes. The right implementation sh

Re: [Qemu-devel] Correction needed for R5900 instruction decoding

2018-11-02 Thread Fredrik Noring
Hi Peter, > From the other side of things, as a submaintainer around release > time there's often a lot of work to do and it's easy to confuse > different patchsets or forget the status of them, so it's useful > to have a patch series which is exactly the set of patches that > the submitter thinks

Re: [Qemu-devel] Correction needed for R5900 instruction decoding

2018-11-02 Thread Peter Maydell
On 2 November 2018 at 15:03, Aleksandar Markovic wrote: > Hi, Fredrik. > >> From: Fredrik Noring >> Subject: Re: [Qemu-devel] Correction needed for R5900 instruction decoding >> >> Hi Aleksandar, >> >> > It is now code freeze before 3.1, the code base

Re: [Qemu-devel] Correction needed for R5900 instruction decoding

2018-11-02 Thread Aleksandar Markovic
Hi, Fredrik. > From: Fredrik Noring > Subject: Re: [Qemu-devel] Correction needed for R5900 instruction decoding > > Hi Aleksandar, > > > It is now code freeze before 3.1, the code base is being stabilized, and > > only important fixes are allowed to be integr

Re: [Qemu-devel] Correction needed for R5900 instruction decoding

2018-11-02 Thread Fredrik Noring
Hi Aleksandar, > It is now code freeze before 3.1, the code base is being stabilized, and > only important fixes are allowed to be integrated - so, in that light, a > separate patch, or a small series, that addresses only concerns from the > original mail of this thread is needed. Such series shou

Re: [Qemu-devel] Correction needed for R5900 instruction decoding

2018-11-02 Thread Aleksandar Markovic
arkovic; Petar Jovanovic; Aleksandar Rikalo; Maciej W. Rozycki; Jürgen Urban; qemu-devel@nongnu.org Subject: Re: [Qemu-devel] Correction needed for R5900 instruction decoding [ Philippe and Emilio -- thank you for cc-ing me. Good catch, since I'm not subscribed to the QEMU mailing list. Cha

Re: [Qemu-devel] Correction needed for R5900 instruction decoding

2018-11-01 Thread Aleksandar Markovic
6:23:53 PM To: Philippe Mathieu-Daudé; Emilio G. Cota; Aleksandar Markovic Cc: Stefan Markovic; Petar Jovanovic; Aleksandar Rikalo; Maciej W. Rozycki; Jürgen Urban; qemu-devel@nongnu.org Subject: Re: [Qemu-devel] Correction needed for R5900 instruction decoding [ Philippe and Emilio -- thank you

Re: [Qemu-devel] Correction needed for R5900 instruction decoding

2018-11-01 Thread Fredrik Noring
[ Philippe and Emilio -- thank you for cc-ing me. Good catch, since I'm not subscribed to the QEMU mailing list. Changes to the R5900 emulation are certainly of interest. ] Hi Aleksandar, Philippe, On Thu, Nov 01, 2018 at 03:31:54PM +0100, Philippe Mathieu-Daudé wrote: > Cc'ing Fredrik. > > On 1

Re: [Qemu-devel] Correction needed for R5900 instruction decoding

2018-11-01 Thread Emilio G. Cota
Cc'ing Fredrik, who I think was the intended recipient of the below. E. On Thu, Nov 01, 2018 at 11:06:30 +, Aleksandar Markovic wrote: > Hi, Fridrik, > > I did some closer code inspection of R5900 in last few days, and I noticed > some sub-optimal implementation in the area

Re: [Qemu-devel] Correction needed for R5900 instruction decoding

2018-11-01 Thread Philippe Mathieu-Daudé
Cc'ing Fredrik. On 1/11/18 12:06, Aleksandar Markovic wrote: Hi, Fridrik, I did some closer code inspection of R5900 in last few days, and I noticed some sub-optimal implementation in the area where R5900-specific opcodes overlap with the rest-of-MIPS-CPUs opcodes. The right implementation s

[Qemu-devel] Correction needed for R5900 instruction decoding

2018-11-01 Thread Aleksandar Markovic
Hi, Fridrik, I did some closer code inspection of R5900 in last few days, and I noticed some sub-optimal implementation in the area where R5900-specific opcodes overlap with the rest-of-MIPS-CPUs opcodes. The right implementation should be based on the principle that all such cases are covered