On 05/11/11 13:33, Jan Vesely wrote:
glad I could help
the original bug report is here: https://bugs.launchpad.net/qemu/+bug/757654
should I update it? or will it be updated when the patch reaches master?
Better wait until the stuff hits master, that is less confusing and you
can also add the
glad I could help
the original bug report is here: https://bugs.launchpad.net/qemu/+bug/757654
should I update it? or will it be updated when the patch reaches master?
j.
On Mon, May 9, 2011 at 1:43 PM, Gerd Hoffmann wrote:
> On 05/09/11 12:16, Jan Vesely wrote:
>>
>> UHCI host controller statu
On 05/09/11 12:16, Jan Vesely wrote:
UHCI host controller status register indicates error and
an interrupt is triggered on BABBLE and STALL errors.
Queued up.
thanks,
Gerd
UHCI host controller status register indicates error and
an interrupt is triggered on BABBLE and STALL errors.
Signed-off-by: Jan Vesely
---
hw/usb-uhci.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
index a65e0b3..1e9c1e7 100644
--- a
On 05/06/11 10:07, Jan Vesely wrote:
hi,
using the modified (single line) patch only works half-way, it sets
the value in status register (guess that's what that line does :))
but hw interrupt is not generated.
I tried adding uhci_update_irq and this patch:
+s->status |= UHCI_STS_USBE
hi,
using the modified (single line) patch only works half-way, it sets
the value in status register (guess that's what that line does :))
but hw interrupt is not generated.
I tried adding uhci_update_irq and this patch:
diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
index a65e0b3..1e9c1e7 100644
---
diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
index 346db3e..a51d89b 100644
--- a/hw/usb-uhci.c
+++ b/hw/usb-uhci.c
@@ -732,11 +732,21 @@ out:
case USB_RET_STALL:
td->ctrl |= TD_CTRL_STALL;
td->ctrl&= ~TD_CTRL_ACTIVE;
+s->status |= UHCI_STS_USBERR;
Just this line s
On Sat, Apr 16, 2011 at 8:33 AM, Brad Hards wrote:
> On Sat, 16 Apr 2011 06:57:00 am Jan Vesely wrote:
>> + s->status |= UHCI_STS_USBERR;
> This is per UHCI 1.1D Section 4.1.5. Looks good.
>
>> + *int_mask |= 0x02;
>> + if (td->ctrl & TD_CTRL_IOC)
>> + *int_mask |=
On Sat, 16 Apr 2011 06:57:00 am Jan Vesely wrote:
> +s->status |= UHCI_STS_USBERR;
This is per UHCI 1.1D Section 4.1.5. Looks good.
> +*int_mask |= 0x02;
> +if (td->ctrl & TD_CTRL_IOC)
> +*int_mask |= 0x01;
> +uhci_update_irq(s);
I see "A hardware interr
Hi,
I'm sending a patch for bug #757654. The bug does not really break
anything it just makes USB error detection harder.
It's a quick fix and might need some polishing but it works (I am
currently using it).
thx,
jan
PS: I guess you need this line:
Signed-off-by: Jan Vesely
diff --git a/hw/us
10 matches
Mail list logo
