Re: [Qemu-devel] AioContext locking vs. coroutines (was: [PATCH] mirror dead-lock)

2018-11-30 Thread Paolo Bonzini
On 29/11/18 11:42, Kevin Wolf wrote: > I guess in this specific instance we can just remove the locking from > mirror_read/write_complete becasue it's only locking an AioContext whose > lock we already hold anyway because we're in a Coroutine owned by the > AioContext, so yielding will release the

Re: [Qemu-devel] AioContext locking vs. coroutines

2018-11-29 Thread Vladimir Sementsov-Ogievskiy
29.11.2018 13:42, Kevin Wolf wrote: > Am 28.11.2018 um 21:13 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Hi all! >> >> We've faced the following mirror bug: >> >> Just run mirror on qcow2 image more than 1G, and qemu is in dead lock. >> >> Note: I've decided to send this as a patch with reprod

[Qemu-devel] AioContext locking vs. coroutines (was: [PATCH] mirror dead-lock)

2018-11-29 Thread Kevin Wolf
Am 28.11.2018 um 21:13 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > We've faced the following mirror bug: > > Just run mirror on qcow2 image more than 1G, and qemu is in dead lock. > > Note: I've decided to send this as a patch with reproducer, to make it > easier to reproduce). N