Re: [Qemu-devel] [PATCH v6 19/26] exec: Delete DEVICE_HOST_ENDIAN

2019-08-07 Thread Richard Henderson
On 8/7/19 3:22 AM, Paolo Bonzini wrote: > On 07/08/19 10:32, tony.ngu...@bt.com wrote: >> +#if defined(HOST_WORDS_BIGENDIAN) >> +    .endianness = MO_BE, >> +#else >> +    .endianness = MO_LE, >> +#endif > > Host endianness is just 0, isn't it? Yes. Just leaving a comment to that effect here for

Re: [Qemu-devel] [PATCH v6 19/26] exec: Delete DEVICE_HOST_ENDIAN

2019-08-07 Thread Paolo Bonzini
On 07/08/19 10:32, tony.ngu...@bt.com wrote: > +#if defined(HOST_WORDS_BIGENDIAN) > +    .endianness = MO_BE, > +#else > +    .endianness = MO_LE, > +#endif Host endianness is just 0, isn't it? Paolo

[Qemu-devel] [PATCH v6 19/26] exec: Delete DEVICE_HOST_ENDIAN

2019-08-07 Thread tony.nguyen
DEVICE_HOST_ENDIAN is conditional upon HOST_WORDS_BIGENDIAN. Code is cleaner if the single use of DEVICE_HOST_ENDIAN is instead directly conditional upon HOST_WORDS_BIGENDIAN. Signed-off-by: Tony Nguyen --- include/exec/cpu-common.h | 8 memory.c | 6 +- 2 files ch