Re: [Qemu-devel] [PATCH v6 1/2] Implement .hex file loader

2018-05-09 Thread Stefan Hajnoczi
On Mon, May 7, 2018 at 10:27 AM, Su Hang wrote: >> > +size_t total_size = 0; >> >> Please use int instead of size_t (see above for reasons). > I have question here: > Since `EXT_LINEAR_ADDR_RECORD` supports 32 bit addressing (up to 4GiB), is > `int` > big enough for this type? > The same ques

Re: [Qemu-devel] [PATCH v6 1/2] Implement .hex file loader

2018-05-07 Thread Su Hang
> > +size_t total_size = 0; > > Please use int instead of size_t (see above for reasons). I have question here: Since `EXT_LINEAR_ADDR_RECORD` supports 32 bit addressing (up to 4GiB), is `int` big enough for this type? The same question will happen to other similar cases. Or should I use `long

Re: [Qemu-devel] [PATCH v6 1/2] Implement .hex file loader

2018-04-30 Thread Su Hang
your review. Su Hang > -Original Messages- > From: "Stefan Hajnoczi" > Sent Time: 2018-04-30 22:23:40 (Monday) > To: "Su Hang" > Cc: j...@groklearning.com, j...@jms.id.au, qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH v6 1/2] Implement .hex f

Re: [Qemu-devel] [PATCH v6 1/2] Implement .hex file loader

2018-04-30 Thread Stefan Hajnoczi
On Thu, Apr 26, 2018 at 09:51:37PM +0800, Su Hang wrote: > if (arm_feature(&cpu->env, ARM_FEATURE_AARCH64) && kernel_size < 0) { > kernel_size = load_aarch64_image(info->kernel_filename, > info->loader_start, &entry, as); > is_linux =

[Qemu-devel] [PATCH v6 1/2] Implement .hex file loader

2018-04-26 Thread Su Hang
This patch adds Intel Hexadecimal Object File format support to the loader. The file format specification is available here: http://www.piclist.com/techref/fileext/hex/intel.htm The file format is mainly intended for embedded systems and microcontrollers, such as Micro:bit Arduino, ARM, STM32, et