Re: [Qemu-devel] [PATCH v3 0/4] fix debug macro pattern for vmxnet3

2015-12-13 Thread Jason Wang
On 12/08/2015 02:29 PM, Dmitry Fleytman wrote: > > Reviewed-by: Dmitry Fleytman > > >> On 8 Dec 2015, at 07:28 AM, Miao Yan > > wrote: >> >> This patchset fixes debug macro pattern for vmxnet3. The old style uses >> #ifdef...#else...#endif

Re: [Qemu-devel] [PATCH v3 0/4] fix debug macro pattern for vmxnet3

2015-12-07 Thread Dmitry Fleytman
Reviewed-by: Dmitry Fleytman mailto:dmi...@daynix.com>> > On 8 Dec 2015, at 07:28 AM, Miao Yan wrote: > > This patchset fixes debug macro pattern for vmxnet3. The old style uses > #ifdef...#else...#endif to define debug macros, as a result > the format string inside the macro will never be chec

[Qemu-devel] [PATCH v3 0/4] fix debug macro pattern for vmxnet3

2015-12-07 Thread Miao Yan
This patchset fixes debug macro pattern for vmxnet3. The old style uses #ifdef...#else...#endif to define debug macros, as a result the format string inside the macro will never be checked (debug not turned on by default) and is likely to cause build errors in the future when enabled. Changes in