Re: [Qemu-devel] [PATCH V3] hw/virtio-pci: fix virtio behaviour

2016-07-22 Thread Marcel Apfelbaum
On 07/22/2016 01:21 AM, Michael S. Tsirkin wrote: On Thu, Jul 21, 2016 at 11:58:52PM +0200, Gerd Hoffmann wrote: Hi, Actually this can still break existing scripts: stick a device on express bus but add disable-modern=on Gave you a legacy device previously but it no longer does. Unlikely

Re: [Qemu-devel] [PATCH V3] hw/virtio-pci: fix virtio behaviour

2016-07-22 Thread Marcel Apfelbaum
On 07/21/2016 11:18 PM, Michael S. Tsirkin wrote: On Wed, Jul 20, 2016 at 06:28:21PM +0300, Marcel Apfelbaum wrote: Enable transitional virtio devices by default. Enable virtio-1.0 for devices plugged into disable legacy is better, I agree. PCIe ports (Root ports or Downstream ports). Using

Re: [Qemu-devel] [PATCH V3] hw/virtio-pci: fix virtio behaviour

2016-07-21 Thread Michael S. Tsirkin
On Thu, Jul 21, 2016 at 11:58:52PM +0200, Gerd Hoffmann wrote: > Hi, > > > Actually this can still break existing scripts: > > stick a device on express bus but add disable-modern=on > > Gave you a legacy device previously but it no longer does. > > Unlikely to happen in practice because there

Re: [Qemu-devel] [PATCH V3] hw/virtio-pci: fix virtio behaviour

2016-07-21 Thread Gerd Hoffmann
Hi, > Actually this can still break existing scripts: > stick a device on express bus but add disable-modern=on > Gave you a legacy device previously but it no longer does. Unlikely to happen in practice because there is little reason to use disable-modern=on in 2.6 & older because that is the

Re: [Qemu-devel] [PATCH V3] hw/virtio-pci: fix virtio behaviour

2016-07-21 Thread Michael S. Tsirkin
On Wed, Jul 20, 2016 at 06:28:21PM +0300, Marcel Apfelbaum wrote: > Enable transitional virtio devices by default. > Enable virtio-1.0 for devices plugged into > PCIe ports (Root ports or Downstream ports). > > Using the virtio-1 mode will remove the limitation > of the number of devices that can

Re: [Qemu-devel] [PATCH V3] hw/virtio-pci: fix virtio behaviour

2016-07-21 Thread Michael S. Tsirkin
On Wed, Jul 20, 2016 at 06:28:21PM +0300, Marcel Apfelbaum wrote: > Enable transitional virtio devices by default. > Enable virtio-1.0 for devices plugged into disable legacy is better, I agree. > PCIe ports (Root ports or Downstream ports). > > Using the virtio-1 mode will remove the limitation

Re: [Qemu-devel] [PATCH V3] hw/virtio-pci: fix virtio behaviour

2016-07-21 Thread Cornelia Huck
On Thu, 21 Jul 2016 12:26:03 +0300 Marcel Apfelbaum wrote: > On 07/21/2016 11:54 AM, Cornelia Huck wrote: > > On Wed, 20 Jul 2016 18:28:21 +0300 > > Marcel Apfelbaum wrote: > > > >> Enable transitional virtio devices by default. > >> Enable virtio-1.0 for devices plugged into > >> PCIe ports (Ro

Re: [Qemu-devel] [PATCH V3] hw/virtio-pci: fix virtio behaviour

2016-07-21 Thread Marcel Apfelbaum
On 07/21/2016 11:54 AM, Cornelia Huck wrote: On Wed, 20 Jul 2016 18:28:21 +0300 Marcel Apfelbaum wrote: Enable transitional virtio devices by default. Enable virtio-1.0 for devices plugged into PCIe ports (Root ports or Downstream ports). Hi Cornelia, Thank you for the review. Add "by de

Re: [Qemu-devel] [PATCH V3] hw/virtio-pci: fix virtio behaviour

2016-07-21 Thread Cornelia Huck
On Wed, 20 Jul 2016 18:28:21 +0300 Marcel Apfelbaum wrote: > Enable transitional virtio devices by default. > Enable virtio-1.0 for devices plugged into > PCIe ports (Root ports or Downstream ports). Add "by default", as this can still be overridden? > > Using the virtio-1 mode will remove the

Re: [Qemu-devel] [PATCH V3] hw/virtio-pci: fix virtio behaviour

2016-07-20 Thread Gerd Hoffmann
On Mi, 2016-07-20 at 18:28 +0300, Marcel Apfelbaum wrote: > Enable transitional virtio devices by default. > Enable virtio-1.0 for devices plugged into > PCIe ports (Root ports or Downstream ports). > > Using the virtio-1 mode will remove the limitation > of the number of devices that can be attac

Re: [Qemu-devel] [PATCH V3] hw/virtio-pci: fix virtio behaviour

2016-07-20 Thread Marcel Apfelbaum
On 07/20/2016 06:28 PM, Marcel Apfelbaum wrote: Enable transitional virtio devices by default. Enable virtio-1.0 for devices plugged into PCIe ports (Root ports or Downstream ports). Using the virtio-1 mode will remove the limitation of the number of devices that can be attached to a machine by

[Qemu-devel] [PATCH V3] hw/virtio-pci: fix virtio behaviour

2016-07-20 Thread Marcel Apfelbaum
Enable transitional virtio devices by default. Enable virtio-1.0 for devices plugged into PCIe ports (Root ports or Downstream ports). Using the virtio-1 mode will remove the limitation of the number of devices that can be attached to a machine by removing the need for the IO BAR. Signed-off-by: