Re: [Qemu-devel] [PATCH RFC V2 0/9] qemu-machine as a QOM object

2014-03-03 Thread Andreas Färber
Am 03.03.2014 14:17, schrieb Marcel Apfelbaum: > On Mon, 2014-03-03 at 13:56 +0100, Paolo Bonzini wrote: >> Il 03/03/2014 13:07, Marcel Apfelbaum ha scritto: >>> I see no reason why not, the main problem I see is the use of those wrappers >>> or setters/getters, I suspect that the usage will be: >>

Re: [Qemu-devel] [PATCH RFC V2 0/9] qemu-machine as a QOM object

2014-03-03 Thread Marcel Apfelbaum
On Mon, 2014-03-03 at 13:56 +0100, Paolo Bonzini wrote: > Il 03/03/2014 13:07, Marcel Apfelbaum ha scritto: > >> Another early refactoring should be to pass ¤t_machine->init_args > >> to machine->init, not the "args". > > Problem is that this is a "private field", should I add a getter for it? > >

Re: [Qemu-devel] [PATCH RFC V2 0/9] qemu-machine as a QOM object

2014-03-03 Thread Paolo Bonzini
Il 03/03/2014 13:07, Marcel Apfelbaum ha scritto: Another early refactoring should be to pass ¤t_machine->init_args to machine->init, not the "args". Problem is that this is a "private field", should I add a getter for it? vl.c is already accessing it one line before, isn't it? So vl.c is alr

Re: [Qemu-devel] [PATCH RFC V2 0/9] qemu-machine as a QOM object

2014-03-03 Thread Marcel Apfelbaum
On Mon, 2014-03-03 at 11:50 +0100, Paolo Bonzini wrote: > Il 02/03/2014 14:07, Marcel Apfelbaum ha scritto: > > Most of the "Cc" list is due to patch 8: (Should I send each patch to a > > different list?) > > machine-opts: replace qemu_opt_get by QOM QemuMachine queries. > > > > Status: > >

Re: [Qemu-devel] [PATCH RFC V2 0/9] qemu-machine as a QOM object

2014-03-03 Thread Paolo Bonzini
Il 02/03/2014 14:07, Marcel Apfelbaum ha scritto: Most of the "Cc" list is due to patch 8: (Should I send each patch to a different list?) machine-opts: replace qemu_opt_get by QOM QemuMachine queries. Status: - machine_opts are mapped into QemuMachineState's properties, which can

[Qemu-devel] [PATCH RFC V2 0/9] qemu-machine as a QOM object

2014-03-02 Thread Marcel Apfelbaum
Most of the "Cc" list is due to patch 8: (Should I send each patch to a different list?) machine-opts: replace qemu_opt_get by QOM QemuMachine queries. Status: - machine_opts are mapped into QemuMachineState's properties, which can be queried as regular QOM properties. - Subclas