Re: [Qemu-devel] [PATCH] util: Relax assertion in iov_copy()

2016-08-01 Thread Paolo Bonzini
On 25/07/2016 13:43, Shmulik Ladkani wrote: > From: Shmulik Ladkani > > In cases where iov_copy() is passed with zero 'bytes' argument and a > non-zero 'offset' argument, nothing gets copied - as expected. > > However since no copy iterations are performed, 'offset' is left > unaltered, leadin

Re: [Qemu-devel] [PATCH] util: Relax assertion in iov_copy()

2016-07-26 Thread Michael S. Tsirkin
On Mon, Jul 25, 2016 at 02:43:35PM +0300, Shmulik Ladkani wrote: > From: Shmulik Ladkani > > In cases where iov_copy() is passed with zero 'bytes' argument and a > non-zero 'offset' argument, nothing gets copied - as expected. > > However since no copy iterations are performed, 'offset' is left

[Qemu-devel] [PATCH] util: Relax assertion in iov_copy()

2016-07-25 Thread Shmulik Ladkani
From: Shmulik Ladkani In cases where iov_copy() is passed with zero 'bytes' argument and a non-zero 'offset' argument, nothing gets copied - as expected. However since no copy iterations are performed, 'offset' is left unaltered, leading to the final assert(offset == 0) to fail. Relax the asser