Re: [Qemu-devel] [PATCH] scsi-disk: fix crash on VERIFY command

2017-01-03 Thread Paolo Bonzini
On 03/01/2017 10:58, Zhang Qian wrote: > > At 2017-01-03 17:38:49, Paolo Bonzini wrote: >> >> >>On 03/01/2017 09:12, Zhang Qian wrote: >>> yes, you are right. >>> The scenarios of problem is >>> a scsi-disk object receives VERIFY command with BYTCHK bit being zero, >>> scsi_block_is_passthrough

Re: [Qemu-devel] [PATCH] scsi-disk: fix crash on VERIFY command

2017-01-03 Thread Zhang Qian
At 2017-01-03 17:38:49, Paolo Bonzini wrote: > > >On 03/01/2017 09:12, Zhang Qian wrote: >> yes, you are right. >> The scenarios of problem is >> a scsi-disk object receives VERIFY command with BYTCHK bit being zero, >> scsi_block_is_passthrough returns false and finally scsi-block uses >> scsi_d

Re: [Qemu-devel] [PATCH] scsi-disk: fix crash on VERIFY command

2017-01-03 Thread Paolo Bonzini
On 03/01/2017 09:12, Zhang Qian wrote: > yes, you are right. > The scenarios of problem is > a scsi-disk object receives VERIFY command with BYTCHK bit being zero, > scsi_block_is_passthrough returns false and finally scsi-block uses > scsi_disk_dma_command for > VERIFY. So the mode is set to SCS

Re: [Qemu-devel] [PATCH] scsi-disk: fix crash on VERIFY command

2017-01-03 Thread Zhang Qian
At 2017-01-02 17:34:00, Paolo Bonzini wrote: > > >On 29/12/2016 13:19, Zhang Qian wrote: >> From c2f1631132821d61e1942a8723ba596f91d3e672 Mon Sep 17 00:00:00 2001 >> From: Zhang Qian >> Date: Thu, 29 Dec 2016 20:00:01 +0800 >> Subject: [PATCH] scsi-disk: fix crash on VERIFY command Commit 166dbda

Re: [Qemu-devel] [PATCH] scsi-disk: fix crash on VERIFY command

2017-01-02 Thread Paolo Bonzini
On 29/12/2016 13:19, Zhang Qian wrote: > From c2f1631132821d61e1942a8723ba596f91d3e672 Mon Sep 17 00:00:00 2001 > From: Zhang Qian > Date: Thu, 29 Dec 2016 20:00:01 +0800 > Subject: [PATCH] scsi-disk: fix crash on VERIFY command Commit 166dbda > "scsi-disk: fix VERIFY for scsi-block" add a proc

[Qemu-devel] [PATCH] scsi-disk: fix crash on VERIFY command

2016-12-29 Thread Zhang Qian
From c2f1631132821d61e1942a8723ba596f91d3e672 Mon Sep 17 00:00:00 2001 From: Zhang Qian Date: Thu, 29 Dec 2016 20:00:01 +0800 Subject: [PATCH] scsi-disk: fix crash on VERIFY command Commit 166dbda "scsi-disk: fix VERIFY for scsi-block" add a process of VERIFY in scsi_block_dma_command. But, the