Re: [Qemu-devel] [PATCH] net/vmxnet3: Refine l2 header validation

2015-09-23 Thread Jason Wang
On 09/18/2015 02:13 PM, Shmulik Ladkani wrote: > Hi, > > On Thu, 3 Sep 2015 17:45:34 +0100 Stefan Hajnoczi wrote: >> Thanks, applied to my net tree: >> https://github.com/stefanha/qemu/commits/net > For some reason, the patch isn't present on Stefan's last pull requests. > > Can you please verif

Re: [Qemu-devel] [PATCH] net/vmxnet3: Refine l2 header validation

2015-09-17 Thread Shmulik Ladkani
Hi, On Thu, 3 Sep 2015 17:45:34 +0100 Stefan Hajnoczi wrote: > Thanks, applied to my net tree: > https://github.com/stefanha/qemu/commits/net For some reason, the patch isn't present on Stefan's last pull requests. Can you please verify this gets merged? Thanks, Shmulik

Re: [Qemu-devel] [PATCH] net/vmxnet3: Refine l2 header validation

2015-09-03 Thread Stefan Hajnoczi
On Tue, Aug 18, 2015 at 12:45:55PM +0300, Shmulik Ladkani wrote: > From: Dana Rubin > > Validation of l2 header length assumed minimal packet size as > eth_header + 2 * vlan_header regardless of the actual protocol. > > This caused crash for valid non-IP packets shorter than 22 bytes, as > 'tx_p

Re: [Qemu-devel] [PATCH] net/vmxnet3: Refine l2 header validation

2015-08-19 Thread Dmitry Fleytman
ACK. > On Aug 18, 2015, at 02:45 AM, Shmulik Ladkani > wrote: > > From: Dana Rubin > > Validation of l2 header length assumed minimal packet size as > eth_header + 2 * vlan_header regardless of the actual protocol. > > This caused crash for valid non-IP packets shorter than 22 bytes, as > 't

[Qemu-devel] [PATCH] net/vmxnet3: Refine l2 header validation

2015-08-18 Thread Shmulik Ladkani
From: Dana Rubin Validation of l2 header length assumed minimal packet size as eth_header + 2 * vlan_header regardless of the actual protocol. This caused crash for valid non-IP packets shorter than 22 bytes, as 'tx_pkt->packet_type' hasn't been assigned for such packets, and 'vmxnet3_on_tx_done