Re: [Qemu-devel] [PATCH] Put all trace.o into libqemuutil.a

2017-04-06 Thread Stefan Hajnoczi
On Tue, Apr 04, 2017 at 09:39:39PM +, Xu, Anthony wrote: Thanks, applied to my tracing-next tree: https://github.com/stefanha/qemu/commits/tracing-next I fixed up the patch when applying it. Comments below: > Put all trace.o into libqemuutil.a Please use the "trace: " prefix for tracing pa

Re: [Qemu-devel] [PATCH] Put all trace.o into libqemuutil.a

2017-04-06 Thread Stefan Hajnoczi
On Wed, Apr 05, 2017 at 11:15:58AM +0300, Lluís Vilanova wrote: > Xu, Anthony writes: > > > Put all trace.o into libqemuutil.a > > Currently all trace.o are linked into qemu-system, qemu-img, > > qemu-nbd, qemu-io etc., even the corresponding components > > are not included. > > Put all trace.o

Re: [Qemu-devel] [PATCH] Put all trace.o into libqemuutil.a

2017-04-05 Thread Daniel P. Berrange
On Tue, Apr 04, 2017 at 09:39:39PM +, Xu, Anthony wrote: > Put all trace.o into libqemuutil.a > > Currently all trace.o are linked into qemu-system, qemu-img, > qemu-nbd, qemu-io etc., even the corresponding components > are not included. > Put all trace.o into libqemuutil.a that the linker

Re: [Qemu-devel] [PATCH] Put all trace.o into libqemuutil.a

2017-04-05 Thread Lluís Vilanova
Xu, Anthony writes: > Put all trace.o into libqemuutil.a > Currently all trace.o are linked into qemu-system, qemu-img, > qemu-nbd, qemu-io etc., even the corresponding components > are not included. > Put all trace.o into libqemuutil.a that the linker would only pull in .o > files containing s

[Qemu-devel] [PATCH] Put all trace.o into libqemuutil.a

2017-04-04 Thread Xu, Anthony
Put all trace.o into libqemuutil.a Currently all trace.o are linked into qemu-system, qemu-img, qemu-nbd, qemu-io etc., even the corresponding components are not included. Put all trace.o into libqemuutil.a that the linker would only pull in .o files containing symbols that are actually referen