Re: [Qemu-devel] -cc checking wrong

2006-05-08 Thread Jim C. Brown
On Mon, May 08, 2006 at 08:53:29PM +0200, Pavel Jan?k wrote: > >> check that the first arg is -x > > This is also incorrect. > > [EMAIL PROTECTED]:/tmp> alias compiler=gcc > [EMAIL PROTECTED]:/tmp> compiler -v > Reading specs from /usr/lib/gcc-lib/i586-suse-linux/3.3.5/specs > [...] > [EMAIL

Re: [Qemu-devel] -cc checking wrong

2006-05-08 Thread Pavel Janík
From: "Jim C. Brown" <[EMAIL PROTECTED]> Date: Mon, 8 May 2006 11:12:54 -0400 > Maybe make the check into a function, and if the first arg is distcc or ccache, Do you know icecast or compilercache? Sorry, this is incorrect way by definition. > check that the first arg is -x This is

Re: [Qemu-devel] -cc checking wrong

2006-05-08 Thread Jim C. Brown
On Mon, May 08, 2006 at 09:52:12AM +0200, Pavel Jan?k wrote: >From: "Jim C. Brown" <[EMAIL PROTECTED]> >Date: Sun, 7 May 2006 20:34:11 -0400 > >> The right thing to do might be to check if the first arg is ccache, >> and if so check for both ccache and the 2nd compiler. Especially

Re: [Qemu-devel] -cc checking wrong

2006-05-08 Thread Pavel Janík
From: "Jim C. Brown" <[EMAIL PROTECTED]> Date: Sun, 7 May 2006 20:34:11 -0400 > The right thing to do might be to check if the first arg is ccache, > and if so check for both ccache and the 2nd compiler. Especially if > ccache is the only compiler that requires arguments be passed t

Re: [Qemu-devel] -cc checking wrong

2006-05-07 Thread Jim C. Brown
On Mon, May 08, 2006 at 01:53:03AM +0100, Paul Brook wrote: > You really should test your patches. The patch you attached generates an > error > if the compiler works. > > Paul > Whoops, sorry about that. I only tested the --cc="ccache gcc" case. Here's the correct patch. -- Infinite comple

Re: [Qemu-devel] -cc checking wrong

2006-05-07 Thread Paul Brook
On Monday 08 May 2006 01:18, Jim C. Brown wrote: > On Mon, May 08, 2006 at 12:46:24AM +0200, Pavel Jan?k wrote: > > configure contains: > > > > if [ ! -x "`which $cc`" ] ; then > > echo "Compiler $cc could not be found" > > exit > > fi > > > > You should check if the command compiles, not i

Re: [Qemu-devel] -cc checking wrong

2006-05-07 Thread Jim C. Brown
On Sun, May 07, 2006 at 08:18:55PM -0400, Jim C. Brown wrote: > On Mon, May 08, 2006 at 12:46:24AM +0200, Pavel Jan?k wrote: > > configure contains: > > > > if [ ! -x "`which $cc`" ] ; then > > echo "Compiler $cc could not be found" > > exit > > fi > > > > You should check if the command

Re: [Qemu-devel] -cc checking wrong

2006-05-07 Thread Jim C. Brown
On Mon, May 08, 2006 at 12:46:24AM +0200, Pavel Jan?k wrote: > configure contains: > > if [ ! -x "`which $cc`" ] ; then > echo "Compiler $cc could not be found" > exit > fi > > You should check if the command compiles, not if it exists and is executable. Patch attached. Simply tries to c

Re: [Qemu-devel] -cc checking wrong

2006-05-07 Thread Pavel Janík
From: [EMAIL PROTECTED] (Pavel Janík) Date: Mon, 01 May 2006 09:41:14 +0200 > [EMAIL PROTECTED]:/tmp/QEMU/qemu-cvs> ./configure --cc="ccache gcc" > Compiler ccache gcc could not be found > [EMAIL PROTECTED]:/tmp/QEMU/qemu-cvs> This comes from revision 1.93 date: 2006-04-23 16:35:

[Qemu-devel] -cc checking wrong

2006-05-01 Thread Pavel Janík
[EMAIL PROTECTED]:/tmp/QEMU/qemu-cvs> ./configure --cc="ccache gcc" Compiler ccache gcc could not be found [EMAIL PROTECTED]:/tmp/QEMU/qemu-cvs> Would be nice to accept environment setting of CC as well. -- Pavel Janík panic("Aarggh: attempting to free lock with active wait queue - shoot Andy"