Re: [Qemu-devel] [virtio-dev][RFC v2 2/2] virtio-sdm: new device specification

2016-08-08 Thread Christian Pinto
Hello Stefan, thanks for the feedback.I will rework the specification and send a v3 patch series. Christian On Thu, Aug 4, 2016 at 10:46 AM, Stefan Hajnoczi wrote: > On Fri, Jul 22, 2016 at 06:18:25PM +0200, Christian Pinto wrote: > > Hello Stefan, > > > > On Tue, Jul 19, 2016 at 10:40 AM, St

Re: [Qemu-devel] [virtio-dev][RFC v2 2/2] virtio-sdm: new device specification

2016-08-04 Thread Stefan Hajnoczi
On Fri, Jul 22, 2016 at 06:18:25PM +0200, Christian Pinto wrote: > Hello Stefan, > > On Tue, Jul 19, 2016 at 10:40 AM, Stefan Hajnoczi > wrote: > > > On Tue, Jul 19, 2016 at 09:47:13AM +0200, Christian Pinto wrote: > > > > > +During the initialization phase the device connects also to the > > >

Re: [Qemu-devel] [virtio-dev][RFC v2 2/2] virtio-sdm: new device specification

2016-07-22 Thread Christian Pinto
Hello Stefan, On Tue, Jul 19, 2016 at 10:40 AM, Stefan Hajnoczi wrote: > On Tue, Jul 19, 2016 at 09:47:13AM +0200, Christian Pinto wrote: > > > > +During the initialization phase the device connects also to the > > > communication > > > > +channel. It has to be noted that the behavior of the dev

Re: [Qemu-devel] [virtio-dev][RFC v2 2/2] virtio-sdm: new device specification

2016-07-19 Thread Stefan Hajnoczi
On Tue, Jul 19, 2016 at 09:47:13AM +0200, Christian Pinto wrote: > > > +During the initialization phase the device connects also to the > > communication > > > +channel. It has to be noted that the behavior of the device is > > > +independent from the communication channel used, that is a detail of

Re: [Qemu-devel] [virtio-dev][RFC v2 2/2] virtio-sdm: new device specification

2016-07-19 Thread Christian Pinto
Hello Stefan, thanks for your comments. On Thu, Jul 14, 2016 at 2:17 PM, Stefan Hajnoczi wrote: > On Tue, Jun 28, 2016 at 01:03:44PM +0200, Christian Pinto wrote: > > This patch adds the specification of the Signal Dristribution Module > virtio > > device to the current virtio specification doc

Re: [Qemu-devel] [virtio-dev][RFC v2 2/2] virtio-sdm: new device specification

2016-07-14 Thread Stefan Hajnoczi
On Tue, Jun 28, 2016 at 01:03:44PM +0200, Christian Pinto wrote: > +\begin{lstlisting} > +struct virtio_sdm_config { > + u8master; The next field has 16-bit alignment so there is a hole in this struct. Three options: 1. Add an explicit u8 padding field. 2. Change master's type from u8 to

Re: [Qemu-devel] [virtio-dev][RFC v2 2/2] virtio-sdm: new device specification

2016-07-14 Thread Stefan Hajnoczi
On Tue, Jun 28, 2016 at 01:03:44PM +0200, Christian Pinto wrote: > This patch adds the specification of the Signal Dristribution Module virtio > device to the current virtio specification document. > > Signed-off-by: Christian Pinto > Signed-off-by: Baptiste Reynal > > --- > v1 -> v2: > - Fixed

[Qemu-devel] [virtio-dev][RFC v2 2/2] virtio-sdm: new device specification

2016-06-28 Thread Christian Pinto
This patch adds the specification of the Signal Dristribution Module virtio device to the current virtio specification document. Signed-off-by: Christian Pinto Signed-off-by: Baptiste Reynal --- v1 -> v2: - Fixed some typos - Removed dependencies from QEMU - Added explanation on how SDM can be