Re: [Qemu-devel] [v9 Patch 4/6]Qemu: Add commandline -drive option 'hostcache'

2011-11-22 Thread Kevin Wolf
Am 22.11.2011 12:17, schrieb Stefan Hajnoczi: > On Tue, Nov 22, 2011 at 9:55 AM, Kevin Wolf wrote: >> Am 22.11.2011 09:10, schrieb supriya kannery: >>> Let us have the implementation for hostcache= as command line option, with >>> the condition that if both cache= and hostcache= are specified toge

Re: [Qemu-devel] [v9 Patch 4/6]Qemu: Add commandline -drive option 'hostcache'

2011-11-22 Thread Stefan Hajnoczi
On Tue, Nov 22, 2011 at 9:55 AM, Kevin Wolf wrote: > Am 22.11.2011 09:10, schrieb supriya kannery: >> Let us have the implementation for hostcache= as command line option, with >> the condition that if both cache= and hostcache= are specified together, >> then depending upon enable/disable value s

Re: [Qemu-devel] [v9 Patch 4/6]Qemu: Add commandline -drive option 'hostcache'

2011-11-22 Thread Kevin Wolf
Am 22.11.2011 09:10, schrieb supriya kannery: > Let us have the implementation for hostcache= as command line option, with > the condition that if both cache= and hostcache= are specified together, > then depending upon enable/disable value specified for hostcache, > corresponding > bit in cache f

Re: [Qemu-devel] [v9 Patch 4/6]Qemu: Add commandline -drive option 'hostcache'

2011-11-22 Thread supriya kannery
Stefan Hajnoczi wrote: On Mon, Nov 21, 2011 at 12:28 PM, supriya kannery wrote: Stefan Hajnoczi wrote: On Thu, Nov 17, 2011 at 5:18 AM, Supriya Kannery wrote: On 11/17/2011 01:36 AM, Stefan Hajnoczi wrote: On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery wrote:

Re: [Qemu-devel] [v9 Patch 4/6]Qemu: Add commandline -drive option 'hostcache'

2011-11-21 Thread Stefan Hajnoczi
On Mon, Nov 21, 2011 at 12:28 PM, supriya kannery wrote: > Stefan Hajnoczi wrote: >> >> On Thu, Nov 17, 2011 at 5:18 AM, Supriya Kannery >> wrote: >> >>> >>> On 11/17/2011 01:36 AM, Stefan Hajnoczi wrote: >>> On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery  wrote: >

Re: [Qemu-devel] [v9 Patch 4/6]Qemu: Add commandline -drive option 'hostcache'

2011-11-21 Thread supriya kannery
Stefan Hajnoczi wrote: On Thu, Nov 17, 2011 at 5:18 AM, Supriya Kannery wrote: On 11/17/2011 01:36 AM, Stefan Hajnoczi wrote: On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery wrote: +if ((hostcache = qemu_opt_get_bool(opts, "hostcache", -1)) != -1) { This do

Re: [Qemu-devel] [v9 Patch 4/6]Qemu: Add commandline -drive option 'hostcache'

2011-11-17 Thread Stefan Hajnoczi
On Thu, Nov 17, 2011 at 5:18 AM, Supriya Kannery wrote: > On 11/17/2011 01:36 AM, Stefan Hajnoczi wrote: >> >> On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery >>  wrote: >>> >>> +        if ((hostcache = qemu_opt_get_bool(opts, "hostcache", -1)) != >>> -1) { >> >> This does not work.  qemu_opt_g

Re: [Qemu-devel] [v9 Patch 4/6]Qemu: Add commandline -drive option 'hostcache'

2011-11-16 Thread Supriya Kannery
On 11/17/2011 01:36 AM, Stefan Hajnoczi wrote: On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery wrote: +if ((hostcache = qemu_opt_get_bool(opts, "hostcache", -1)) != -1) { This does not work. qemu_opt_get_bool() takes a bool default argument and returns a bool. (bool)-1 == true. B

Re: [Qemu-devel] [v9 Patch 4/6]Qemu: Add commandline -drive option 'hostcache'

2011-11-16 Thread Stefan Hajnoczi
On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery wrote: > +        if ((hostcache = qemu_opt_get_bool(opts, "hostcache", -1)) != -1) { This does not work. qemu_opt_get_bool() takes a bool default argument and returns a bool. (bool)-1 == true. But (int)true == 1 and you cannot expect it to ever

[Qemu-devel] [v9 Patch 4/6]Qemu: Add commandline -drive option 'hostcache'

2011-11-10 Thread Supriya Kannery
qemu command option 'hostcache' added to -drive for block devices. While starting a VM from qemu commandline, this option can be used for setting host cache usage for block data access. Signed-off-by: Supriya Kannery --- blockdev.c | 13 + qemu-config.c |4 qemu-o