Re: [Qemu-devel] [v8 08/14] migration: Add the core code of multi-thread compression

2015-05-07 Thread Paolo Bonzini
On 07/05/2015 16:13, Dr. David Alan Gilbert wrote: >> > Perhaps you can add a counter to the CompressParam struct, and sum all >> > counters in norm_mig_pages_transferred/norm_mig_bytes_transferred (the >> > latter probably should just call norm_mig_pages_transferred)? > The 'ram_save_compressed_

Re: [Qemu-devel] [v8 08/14] migration: Add the core code of multi-thread compression

2015-05-07 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 15/04/2015 11:26, Liang Li wrote: > > +if (ret != RAM_SAVE_CONTROL_NOT_SUPP) { > > +if (ret != RAM_SAVE_CONTROL_DELAYED) { > > +if (bytes_xmit > 0) { > > +acct_info.norm_pages++; > > I don't think you c

Re: [Qemu-devel] [v8 08/14] migration: Add the core code of multi-thread compression

2015-05-07 Thread Paolo Bonzini
On 15/04/2015 11:26, Liang Li wrote: > +if (ret != RAM_SAVE_CONTROL_NOT_SUPP) { > +if (ret != RAM_SAVE_CONTROL_DELAYED) { > +if (bytes_xmit > 0) { > +acct_info.norm_pages++; I don't think you can mix non-atomic and atomic increments like this---or if you c

[Qemu-devel] [v8 08/14] migration: Add the core code of multi-thread compression

2015-04-15 Thread Liang Li
Implement the core logic of the multiple thread compression. At this point, multiple thread compression can't co-work with xbzrle yet. Signed-off-by: Liang Li Signed-off-by: Yang Zhang Reviewed-by: Juan Quintela --- arch_init.c | 183 ++--