Re: [Qemu-devel] [v2 Patch 2/9]block: raw-posix image file reopen

2012-08-14 Thread Kevin Wolf
Am 14.08.2012 13:13, schrieb Supriya Kannery: > On 08/10/2012 07:15 PM, Corey Bryant wrote: >> >> >> On 07/30/2012 05:34 PM, Supriya Kannery wrote: > >>> +static int raw_reopen_prepare(BlockDriverState *bs, BDRVReopenState >>> **prs, >>> + int flags) >>> +{ >>> + BDRVRawReopenState *raw_rs = g_ma

Re: [Qemu-devel] [v2 Patch 2/9]block: raw-posix image file reopen

2012-08-14 Thread Supriya Kannery
On 08/10/2012 07:15 PM, Corey Bryant wrote: > > > On 07/30/2012 05:34 PM, Supriya Kannery wrote: >> +static int raw_reopen_prepare(BlockDriverState *bs, BDRVReopenState >> **prs, >> + int flags) >> +{ >> + BDRVRawReopenState *raw_rs = g_malloc0(sizeof(BDRVRawReopenState)); >> + BDRVRawState *s

Re: [Qemu-devel] [v2 Patch 2/9]block: raw-posix image file reopen

2012-08-14 Thread Supriya Kannery
On 07/31/2012 10:47 PM, Eric Blake wrote: > On 07/30/2012 03:34 PM, Supriya Kannery wrote: >> +s->fd = dup3(raw_rs->stash_s->fd, s->fd, O_CLOEXEC); > > You called it out in your cover letter, but just pointing out that this > is one of the locations that needs a conditional fallback to > dup2/

Re: [Qemu-devel] [v2 Patch 2/9]block: raw-posix image file reopen

2012-08-10 Thread Corey Bryant
On 07/30/2012 05:34 PM, Supriya Kannery wrote: raw-posix driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. Signed-off-by: Supriya Kannery --- Index: qemu/block/raw.c ===

Re: [Qemu-devel] [v2 Patch 2/9]block: raw-posix image file reopen

2012-08-08 Thread Jeff Cody
On 07/30/2012 05:34 PM, Supriya Kannery wrote: > raw-posix driver changes for bdrv_reopen_xx functions to > safely reopen image files. Reopening of image files while > changing hostcache dynamically is handled here. > > Signed-off-by: Supriya Kannery > > --- > Index: qemu/block/raw.c >

Re: [Qemu-devel] [v2 Patch 2/9]block: raw-posix image file reopen

2012-08-03 Thread Jeff Cody
On 07/31/2012 01:17 PM, Eric Blake wrote: > On 07/30/2012 03:34 PM, Supriya Kannery wrote: >> raw-posix driver changes for bdrv_reopen_xx functions to >> safely reopen image files. Reopening of image files while >> changing hostcache dynamically is handled here. >> >> Signed-off-by: Supriya Kanner

Re: [Qemu-devel] [v2 Patch 2/9]block: raw-posix image file reopen

2012-07-31 Thread Kevin Wolf
Am 31.07.2012 19:17, schrieb Eric Blake: > On 07/30/2012 03:34 PM, Supriya Kannery wrote: >> raw-posix driver changes for bdrv_reopen_xx functions to >> safely reopen image files. Reopening of image files while >> changing hostcache dynamically is handled here. >> >> Signed-off-by: Supriya Kannery

Re: [Qemu-devel] [v2 Patch 2/9]block: raw-posix image file reopen

2012-07-31 Thread Eric Blake
On 07/30/2012 03:34 PM, Supriya Kannery wrote: > raw-posix driver changes for bdrv_reopen_xx functions to > safely reopen image files. Reopening of image files while > changing hostcache dynamically is handled here. > > Signed-off-by: Supriya Kannery > > --- > Index: qemu/block/raw.c >

[Qemu-devel] [v2 Patch 2/9]block: raw-posix image file reopen

2012-07-30 Thread Supriya Kannery
raw-posix driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. Signed-off-by: Supriya Kannery --- Index: qemu/block/raw.c === --- q