Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-08-10 Thread Stefan Hajnoczi
On Sun, Aug 09, 2015 at 05:03:14PM +0300, Vasiliy Tolstov wrote: > 2015-08-05 21:58 GMT+03:00 Jeff Cody : > > Hi Vasiliy, > > > > If you run configure with --disable-strip, it will not strip the > > debugging symbols from the binary after the build. Then, you can run > > gdb on qemu, and do a bac

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-08-09 Thread Vasiliy Tolstov
2015-08-05 21:58 GMT+03:00 Jeff Cody : > Hi Vasiliy, > > If you run configure with --disable-strip, it will not strip the > debugging symbols from the binary after the build. Then, you can run > gdb on qemu, and do a backtrace after you hit the segfault ('bt'). > That may shed some light, and is

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-08-05 Thread Jeff Cody
On Tue, Aug 04, 2015 at 11:07:16AM +0300, Vasiliy Tolstov wrote: > 2015-08-03 3:41 GMT+03:00 Liu Yuan : > > What did you mean by 'not able to completely install'? It is a installation > > problem or something else? > > > > i have simple test that works as: > 1) boot 3.18.x kernel and initrd with s

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-08-04 Thread Vasiliy Tolstov
2015-08-03 3:41 GMT+03:00 Liu Yuan : > What did you mean by 'not able to completely install'? It is a installation > problem or something else? > i have simple test that works as: 1) boot 3.18.x kernel and initrd with static compiled golang binary 2) binary bringup dhcp network 3) fetch from http

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-08-02 Thread Liu Yuan
On Thu, Jul 30, 2015 at 09:27:44AM -0400, Jeff Cody wrote: > On Thu, Jul 30, 2015 at 09:41:08AM +0300, Vasiliy Tolstov wrote: > > 2015-07-29 12:31 GMT+03:00 Liu Yuan : > > > Technically, it won't affect the performance because index updates are > > > not range > > > but concrete in terms of underl

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-08-02 Thread Liu Yuan
On Sun, Aug 02, 2015 at 02:52:08PM +0300, Vasiliy Tolstov wrote: > 2015-07-31 15:08 GMT+03:00 Vasiliy Tolstov : > > Please wait to performance comparison. As i see Liu's patch may be > > more slow then Hitoshi. > > > I'm switch to local cluster driver to test only local ssd and not > network over

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-08-02 Thread Vasiliy Tolstov
to compare fio results from host system with file places on the ssd (ext4,nodiscard, trimmed before run): randrw: (g=0): rw=randrw, bs=4K-4K/4K-4K, ioengine=libaio, iodepth=32 2.0.8 Starting 10 processes Jobs: 10 (f=10): [mm] [100.0% done] [50892K/49944K /s] [12.8K/12.5K iops] [eta 00m:00s]

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-08-02 Thread Vasiliy Tolstov
2015-07-31 15:08 GMT+03:00 Vasiliy Tolstov : > Please wait to performance comparison. As i see Liu's patch may be > more slow then Hitoshi. I'm switch to local cluster driver to test only local ssd and not network overhead. But now Liu's qemu does not able to completely install vps: sheep runs a

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-08-01 Thread Liu Yuan
On Fri, Jul 31, 2015 at 03:08:09PM +0300, Vasiliy Tolstov wrote: > 2015-07-31 14:55 GMT+03:00 Vasiliy Tolstov : > > Liu's patch also works for me. But also like in Hitoshi patch breaks > > when using discards in qemu =(. > > > Please wait to performance comparison. As i see Liu's patch may be > m

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-07-31 Thread Vasiliy Tolstov
2015-07-31 14:55 GMT+03:00 Vasiliy Tolstov : > Liu's patch also works for me. But also like in Hitoshi patch breaks > when using discards in qemu =(. Please wait to performance comparison. As i see Liu's patch may be more slow then Hitoshi. -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-07-31 Thread Vasiliy Tolstov
2015-07-30 16:27 GMT+03:00 Jeff Cody : > I'd rather see some sort consensus amongst Liu, Hitoshi, yourself, or > others more intimately familiar with sheepdog. > > Right now, we have Hitoshi's patch in the main git repo, slated for > 2.4 release (which is Monday). It sounds, from Liu's email, as t

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-07-30 Thread Jeff Cody
On Thu, Jul 30, 2015 at 09:41:08AM +0300, Vasiliy Tolstov wrote: > 2015-07-29 12:31 GMT+03:00 Liu Yuan : > > Technically, it won't affect the performance because index updates are not > > range > > but concrete in terms of underlying 4M block size. Only 2 or 3 indexes in a > > range will be update

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-07-30 Thread Vasiliy Tolstov
2015-07-30 12:13 GMT+03:00 Liu Yuan : > Hi Vasiliy, > > Did you test my patch? I think both patch can make the problem gone. The > trick is that which way is the right fix. This is quit technical because > sometimes the problem is gone not because being fixed but is covered out. > > If you have pro

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-07-30 Thread Liu Yuan
On Thu, Jul 30, 2015 at 09:41:08AM +0300, Vasiliy Tolstov wrote: > 2015-07-29 12:31 GMT+03:00 Liu Yuan : > > Technically, it won't affect the performance because index updates are not > > range > > but concrete in terms of underlying 4M block size. Only 2 or 3 indexes in a > > range will be update

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-07-29 Thread Vasiliy Tolstov
2015-07-29 12:31 GMT+03:00 Liu Yuan : > Technically, it won't affect the performance because index updates are not > range > but concrete in terms of underlying 4M block size. Only 2 or 3 indexes in a > range will be updated and 90+% updates will be only 1. So if 2 updates stride > a > large rang

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-07-29 Thread Liu Yuan
On Wed, Jul 29, 2015 at 02:04:55PM +0900, Hitoshi Mitake wrote: > At Wed, 29 Jul 2015 12:02:35 +0800, > Liu Yuan wrote: > > > > From: Liu Yuan > > > > Current sheepdog driver use a range update_inode(min_idx, max_idx) for > > batching > > the updates. But there is subtle problem by determining

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-07-28 Thread Hitoshi Mitake
At Wed, 29 Jul 2015 12:02:35 +0800, Liu Yuan wrote: > > From: Liu Yuan > > Current sheepdog driver use a range update_inode(min_idx, max_idx) for > batching > the updates. But there is subtle problem by determining min_idx and max_idx: > > for a single create request, min_idx == max_idx, so ac