Re: [Qemu-devel] [qom/qom-cpu PATCH] i386: invtsc migration blocker is redudant

2014-05-29 Thread Eduardo Habkost
On Thu, May 29, 2014 at 04:00:36PM -0300, Marcelo Tosatti wrote: > On Wed, May 28, 2014 at 01:25:38PM -0300, Eduardo Habkost wrote: > > On Wed, May 28, 2014 at 11:14:14AM +0200, Juan Quintela wrote: > > > Eduardo Habkost wrote: > > > > On Tue, May 27, 2014 at 11:39:20AM -0300, Marcelo Tosatti wrot

Re: [Qemu-devel] [qom/qom-cpu PATCH] i386: invtsc migration blocker is redudant

2014-05-29 Thread Marcelo Tosatti
On Wed, May 28, 2014 at 01:25:38PM -0300, Eduardo Habkost wrote: > On Wed, May 28, 2014 at 11:14:14AM +0200, Juan Quintela wrote: > > Eduardo Habkost wrote: > > > On Tue, May 27, 2014 at 11:39:20AM -0300, Marcelo Tosatti wrote: > > >> > > >> Migration blocker is redudant: blocking savevm is suffi

Re: [Qemu-devel] [qom/qom-cpu PATCH] i386: invtsc migration blocker is redudant

2014-05-28 Thread Eduardo Habkost
On Tue, May 27, 2014 at 10:51:28PM -0300, Marcelo Tosatti wrote: > On Tue, May 27, 2014 at 12:55:01PM -0300, Eduardo Habkost wrote: > > On Tue, May 27, 2014 at 11:39:20AM -0300, Marcelo Tosatti wrote: > > > > > > Migration blocker is redudant: blocking savevm is sufficient. > > > > > > > Removin

Re: [Qemu-devel] [qom/qom-cpu PATCH] i386: invtsc migration blocker is redudant

2014-05-28 Thread Eduardo Habkost
On Wed, May 28, 2014 at 11:14:14AM +0200, Juan Quintela wrote: > Eduardo Habkost wrote: > > On Tue, May 27, 2014 at 11:39:20AM -0300, Marcelo Tosatti wrote: > >> > >> Migration blocker is redudant: blocking savevm is sufficient. > >> > > > > Removing the redundancy looks welcome, but at the same

Re: [Qemu-devel] [qom/qom-cpu PATCH] i386: invtsc migration blocker is redudant

2014-05-28 Thread Juan Quintela
Eduardo Habkost wrote: > On Tue, May 27, 2014 at 11:39:20AM -0300, Marcelo Tosatti wrote: >> >> Migration blocker is redudant: blocking savevm is sufficient. >> > > Removing the redundancy looks welcome, but at the same time the > migrate_add_blocker() call ensured we had a clearer error message

Re: [Qemu-devel] [qom/qom-cpu PATCH] i386: invtsc migration blocker is redudant

2014-05-27 Thread Marcelo Tosatti
On Tue, May 27, 2014 at 12:55:01PM -0300, Eduardo Habkost wrote: > On Tue, May 27, 2014 at 11:39:20AM -0300, Marcelo Tosatti wrote: > > > > Migration blocker is redudant: blocking savevm is sufficient. > > > > Removing the redundancy looks welcome, but at the same time the > migrate_add_blocker(

Re: [Qemu-devel] [qom/qom-cpu PATCH] i386: invtsc migration blocker is redudant

2014-05-27 Thread Eduardo Habkost
On Tue, May 27, 2014 at 11:39:20AM -0300, Marcelo Tosatti wrote: > > Migration blocker is redudant: blocking savevm is sufficient. > Removing the redundancy looks welcome, but at the same time the migrate_add_blocker() call ensured we had a clearer error message (I mean: if we did mention invtsc

[Qemu-devel] [qom/qom-cpu PATCH] i386: invtsc migration blocker is redudant

2014-05-27 Thread Marcelo Tosatti
Migration blocker is redudant: blocking savevm is sufficient. Signed-off-by: Marcelo Tosatti diff --git a/target-i386/kvm.c b/target-i386/kvm.c index f9ffa4b..b29098a 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -450,7 +450,7 @@ static bool hyperv_enabled(X86CPU *cpu)