Re: [Qemu-devel] [qemu-s390x] [PATCH] tests: virtio: separate ccw tests from libqos

2018-08-01 Thread Paolo Bonzini
On 01/08/2018 18:39, Thomas Huth wrote: > I think you could omit the virtio_net_nop test here, since we already > check that device in tests/pxe-test.c (and maybe also virtio_blk and > virtio_scsi since they are tested in tests/cdrom-test.c). > > Anyway: > > Reviewed-by: Thomas Huth Thanks Conn

Re: [Qemu-devel] [qemu-s390x] [PATCH] tests: virtio: separate ccw tests from libqos

2018-08-01 Thread Thomas Huth
On 08/01/2018 03:27 PM, Paolo Bonzini wrote: > Because qtest does not support s390 channel I/O, s390 only performs smoke > tests on > those few devices that do not have any functional tests. Therefore, every > time we > add functional tests for a virtio device, the choice is between removing > t