Re: [Qemu-devel] [patch v5 5/8] memory: introduce local lock for address space

2012-11-05 Thread Avi Kivity
On 11/02/2012 10:00 AM, Jan Kiszka wrote: > > > >> As I understand the series, as->lock == NULL means that we will never > >> take any lock during dispatch as the caller is not yet ready for > >> fine-grained locking. This prevents the problem - for PIO at least. But > >> this series should break

Re: [Qemu-devel] [patch v5 5/8] memory: introduce local lock for address space

2012-11-02 Thread Jan Kiszka
On 2012-11-02 01:52, liu ping fan wrote: > On Fri, Nov 2, 2012 at 2:44 AM, Jan Kiszka wrote: >> On 2012-11-01 16:45, Avi Kivity wrote: >>> On 10/29/2012 11:46 AM, liu ping fan wrote: On Mon, Oct 29, 2012 at 5:32 PM, Avi Kivity wrote: > On 10/29/2012 01:48 AM, Liu Ping Fan wrote: >> F

Re: [Qemu-devel] [patch v5 5/8] memory: introduce local lock for address space

2012-11-01 Thread liu ping fan
On Fri, Nov 2, 2012 at 2:44 AM, Jan Kiszka wrote: > On 2012-11-01 16:45, Avi Kivity wrote: >> On 10/29/2012 11:46 AM, liu ping fan wrote: >>> On Mon, Oct 29, 2012 at 5:32 PM, Avi Kivity wrote: On 10/29/2012 01:48 AM, Liu Ping Fan wrote: > For those address spaces which want to be able ou

Re: [Qemu-devel] [patch v5 5/8] memory: introduce local lock for address space

2012-11-01 Thread Jan Kiszka
On 2012-11-01 16:45, Avi Kivity wrote: > On 10/29/2012 11:46 AM, liu ping fan wrote: >> On Mon, Oct 29, 2012 at 5:32 PM, Avi Kivity wrote: >>> On 10/29/2012 01:48 AM, Liu Ping Fan wrote: For those address spaces which want to be able out of big lock, they will be protected by their own l

Re: [Qemu-devel] [patch v5 5/8] memory: introduce local lock for address space

2012-11-01 Thread Avi Kivity
On 10/29/2012 11:46 AM, liu ping fan wrote: > On Mon, Oct 29, 2012 at 5:32 PM, Avi Kivity wrote: >> On 10/29/2012 01:48 AM, Liu Ping Fan wrote: >>> For those address spaces which want to be able out of big lock, they >>> will be protected by their own local. >>> >>> Signed-off-by: Liu Ping Fan >>

Re: [Qemu-devel] [patch v5 5/8] memory: introduce local lock for address space

2012-10-29 Thread liu ping fan
On Mon, Oct 29, 2012 at 5:32 PM, Avi Kivity wrote: > On 10/29/2012 01:48 AM, Liu Ping Fan wrote: >> For those address spaces which want to be able out of big lock, they >> will be protected by their own local. >> >> Signed-off-by: Liu Ping Fan >> --- >> memory.c | 11 ++- >> memory.h |

Re: [Qemu-devel] [patch v5 5/8] memory: introduce local lock for address space

2012-10-29 Thread Avi Kivity
On 10/29/2012 01:48 AM, Liu Ping Fan wrote: > For those address spaces which want to be able out of big lock, they > will be protected by their own local. > > Signed-off-by: Liu Ping Fan > --- > memory.c | 11 ++- > memory.h |5 - > 2 files changed, 14 insertions(+), 2 deletion

Re: [Qemu-devel] [patch v5 5/8] memory: introduce local lock for address space

2012-10-29 Thread liu ping fan
On Mon, Oct 29, 2012 at 3:42 PM, Peter Maydell wrote: > On 28 October 2012 23:48, Liu Ping Fan wrote: >> For those address spaces which want to be able out of big lock, they >> will be protected by their own local. > > Are you sure this patch compiles? It seems to only be changing > the prototype

Re: [Qemu-devel] [patch v5 5/8] memory: introduce local lock for address space

2012-10-29 Thread Peter Maydell
On 28 October 2012 23:48, Liu Ping Fan wrote: > For those address spaces which want to be able out of big lock, they > will be protected by their own local. Are you sure this patch compiles? It seems to only be changing the prototype and implementation of address_space_init() to take an extra par

[Qemu-devel] [patch v5 5/8] memory: introduce local lock for address space

2012-10-28 Thread Liu Ping Fan
For those address spaces which want to be able out of big lock, they will be protected by their own local. Signed-off-by: Liu Ping Fan --- memory.c | 11 ++- memory.h |5 - 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/memory.c b/memory.c index 2f68d67..ff34ae