Re: [Qemu-devel] [patch 3/4] block stream: add support for partial streaming

2012-01-09 Thread Stefan Hajnoczi
On Mon, Jan 9, 2012 at 10:58 AM, Kevin Wolf wrote: > Am 04.01.2012 23:40, schrieb Stefan Hajnoczi: >> Kevin: I think we need something like qcow2_snapshot_load_tmp() but it >> returns a full new BlockDriverState.  The hard thing is that duping a >> read-only snapshot qcow2 state leads to sharing a

Re: [Qemu-devel] [patch 3/4] block stream: add support for partial streaming

2012-01-09 Thread Kevin Wolf
Am 04.01.2012 23:40, schrieb Stefan Hajnoczi: > The qcow2 implementation never accesses snapshots directly. Instead > there's the concept of the current L1 table, which means there is a > single global state of the disk. Snapshots are immutable and are > never accessed directly, only copied into

Re: [Qemu-devel] [patch 3/4] block stream: add support for partial streaming

2012-01-04 Thread Paolo Bonzini
On 01/04/2012 11:40 PM, Stefan Hajnoczi wrote: What you want sounds almost like an NBD server that can be launched/stopped while qemu is already running a VM. This could be a QEMU monitor command like: nbd-start tcp::1234 virtio-disk0 --snapshot 20120104 It would be possible to stop the server

Re: [Qemu-devel] [patch 3/4] block stream: add support for partial streaming

2012-01-04 Thread Stefan Hajnoczi
On Wed, Jan 4, 2012 at 6:03 PM, Eric Blake wrote: > On 01/04/2012 10:47 AM, Marcelo Tosatti wrote: +/* + * Given an image chain: [BASE] -> [INTER1] -> [INTER2] -> [TOP] + * >>> >>> How hard would it be to go one step further, and provide a monitor >>> command where qemu could dump t

Re: [Qemu-devel] [patch 3/4] block stream: add support for partial streaming

2012-01-04 Thread Marcelo Tosatti
On Wed, Jan 04, 2012 at 11:03:14AM -0700, Eric Blake wrote: > On 01/04/2012 10:47 AM, Marcelo Tosatti wrote: > >>> +/* > >>> + * Given an image chain: [BASE] -> [INTER1] -> [INTER2] -> [TOP] > >>> + * > >> > >> How hard would it be to go one step further, and provide a monitor > >> command where qe

Re: [Qemu-devel] [patch 3/4] block stream: add support for partial streaming

2012-01-04 Thread Eric Blake
On 01/04/2012 10:47 AM, Marcelo Tosatti wrote: >>> +/* >>> + * Given an image chain: [BASE] -> [INTER1] -> [INTER2] -> [TOP] >>> + * >> >> How hard would it be to go one step further, and provide a monitor >> command where qemu could dump the state of BASE, INTER1, or INTER2 >> without removing it

Re: [Qemu-devel] [patch 3/4] block stream: add support for partial streaming

2012-01-04 Thread Marcelo Tosatti
On Wed, Jan 04, 2012 at 09:02:06AM -0700, Eric Blake wrote: > On 01/04/2012 07:08 AM, Marcelo Tosatti wrote: > > Add support for streaming data from an intermediate section of the > > image chain (see patch and documentation for details). > > > > Signed-off-by: Marcelo Tosatti > > > > Index: st

Re: [Qemu-devel] [patch 3/4] block stream: add support for partial streaming

2012-01-04 Thread Eric Blake
On 01/04/2012 07:08 AM, Marcelo Tosatti wrote: > Add support for streaming data from an intermediate section of the > image chain (see patch and documentation for details). > > Signed-off-by: Marcelo Tosatti > > Index: stefanha/block.c > =

[Qemu-devel] [patch 3/4] block stream: add support for partial streaming

2012-01-04 Thread Marcelo Tosatti
Add support for streaming data from an intermediate section of the image chain (see patch and documentation for details). Signed-off-by: Marcelo Tosatti Index: stefanha/block.c === --- stefanha.orig/block.c +++ stefanha/block.c @@