Re: [Qemu-devel] [patch 2/3] Add support for live block copy

2011-02-28 Thread Marcelo Tosatti
On Sat, Feb 26, 2011 at 07:45:44AM -0600, Anthony Liguori wrote: > >>>+- "filename": target image filename (json-string) > >>Is this a created image? Is this an image to create? > >A previously created image. > > > >>To future proof for blockdev, we should make this argument optional > >>and if it

Re: [Qemu-devel] [patch 2/3] Add support for live block copy

2011-02-28 Thread Marcelo Tosatti
On Sat, Feb 26, 2011 at 07:45:44AM -0600, Anthony Liguori wrote: > >>>+- "commit_filename": target commit filename (json-string, optional) > >>I think we should drop this. > >Why? Sorry but this can't wait for non-config persistent storage. This > >mistake was made in the past with irqchip for exam

Re: [Qemu-devel] [patch 2/3] Add support for live block copy

2011-02-26 Thread Anthony Liguori
On 02/25/2011 06:02 PM, Marcelo Tosatti wrote: +- "commit_filename": target commit filename (json-string, optional) I think we should drop this. Why? Sorry but this can't wait for non-config persistent storage. This mistake was made in the past with irqchip for example, lets not r

Re: [Qemu-devel] [patch 2/3] Add support for live block copy

2011-02-26 Thread Anthony Liguori
On 02/25/2011 06:02 PM, Marcelo Tosatti wrote: On Wed, Feb 23, 2011 at 01:06:46PM -0600, Anthony Liguori wrote: On 02/22/2011 11:00 AM, Marcelo Tosatti wrote: Index: qemu/qerror.h === --- qemu.orig/qerror.h +++ qemu/qerro

Re: [Qemu-devel] [patch 2/3] Add support for live block copy

2011-02-25 Thread Marcelo Tosatti
On Wed, Feb 23, 2011 at 01:06:46PM -0600, Anthony Liguori wrote: > On 02/22/2011 11:00 AM, Marcelo Tosatti wrote: > >Index: qemu/qerror.h > >=== > >--- qemu.orig/qerror.h > >+++ qemu/qerror.h > >@@ -171,4 +171,13 @@ QError *qobject_to_

Re: [Qemu-devel] [patch 2/3] Add support for live block copy

2011-02-23 Thread Anthony Liguori
On 02/22/2011 11:00 AM, Marcelo Tosatti wrote: Index: qemu/qerror.h === --- qemu.orig/qerror.h +++ qemu/qerror.h @@ -171,4 +171,13 @@ QError *qobject_to_qerror(const QObject #define QERR_VNC_SERVER_FAILED \ "{ 'class': 'VNCSe

Re: [Qemu-devel] [patch 2/3] Add support for live block copy

2011-02-22 Thread Anthony Liguori
On 02/22/2011 11:00 AM, Marcelo Tosatti wrote: + +static void blkcopy_switch(BdrvCopyState *s) +{ +char src_filename[1024]; +int open_flags; + +strncpy(src_filename, s->src->filename, sizeof(src_filename)); +open_flags = s->src->open_flags; strncpy doesn't leave a NULL termi

[Qemu-devel] [patch 2/3] Add support for live block copy

2011-02-22 Thread Marcelo Tosatti
Support live image copy + switch. That is, copy an image backing a guest hard disk to a destination image (destination image must be created separately), and switch to this copy. Command syntax: block_copy device filename [commit_filename] [-i] -- live block copy device to image o