Re: [Qemu-devel] [for-2.12 3/7] pci: Fold pci_bus.h into pci.h

2017-12-03 Thread David Gibson
On Fri, Dec 01, 2017 at 06:29:39PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 30, 2017 at 03:02:48PM +1100, David Gibson wrote: > > On Wed, Nov 29, 2017 at 12:38:00PM +0200, Marcel Apfelbaum wrote: > > > On 29/11/2017 10:46, David Gibson wrote: > > > > include/hw/pci/pci_bus.h is now very small

Re: [Qemu-devel] [for-2.12 3/7] pci: Fold pci_bus.h into pci.h

2017-12-03 Thread David Gibson
On Sun, Dec 03, 2017 at 07:07:36AM +0200, Michael S. Tsirkin wrote: > On Sat, Dec 02, 2017 at 11:59:20AM +1100, David Gibson wrote: > > On Fri, Dec 01, 2017 at 06:29:39PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 30, 2017 at 03:02:48PM +1100, David Gibson wrote: > > > > On Wed, Nov 29, 201

Re: [Qemu-devel] [for-2.12 3/7] pci: Fold pci_bus.h into pci.h

2017-12-02 Thread Michael S. Tsirkin
On Sat, Dec 02, 2017 at 11:59:20AM +1100, David Gibson wrote: > On Fri, Dec 01, 2017 at 06:29:39PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 30, 2017 at 03:02:48PM +1100, David Gibson wrote: > > > On Wed, Nov 29, 2017 at 12:38:00PM +0200, Marcel Apfelbaum wrote: > > > > On 29/11/2017 10:46,

Re: [Qemu-devel] [for-2.12 3/7] pci: Fold pci_bus.h into pci.h

2017-12-01 Thread David Gibson
On Fri, Dec 01, 2017 at 06:29:39PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 30, 2017 at 03:02:48PM +1100, David Gibson wrote: > > On Wed, Nov 29, 2017 at 12:38:00PM +0200, Marcel Apfelbaum wrote: > > > On 29/11/2017 10:46, David Gibson wrote: > > > > include/hw/pci/pci_bus.h is now very small

Re: [Qemu-devel] [for-2.12 3/7] pci: Fold pci_bus.h into pci.h

2017-12-01 Thread Michael S. Tsirkin
On Thu, Nov 30, 2017 at 03:02:48PM +1100, David Gibson wrote: > On Wed, Nov 29, 2017 at 12:38:00PM +0200, Marcel Apfelbaum wrote: > > On 29/11/2017 10:46, David Gibson wrote: > > > include/hw/pci/pci_bus.h is now very small and can only safely be included > > > after hw/pci/pci.h. So, just fold it

Re: [Qemu-devel] [for-2.12 3/7] pci: Fold pci_bus.h into pci.h

2017-11-30 Thread Marcel Apfelbaum
On 30/11/2017 6:02, David Gibson wrote: On Wed, Nov 29, 2017 at 12:38:00PM +0200, Marcel Apfelbaum wrote: On 29/11/2017 10:46, David Gibson wrote: include/hw/pci/pci_bus.h is now very small and can only safely be included after hw/pci/pci.h. So, just fold it into pci.h. I don't get the bene

Re: [Qemu-devel] [for-2.12 3/7] pci: Fold pci_bus.h into pci.h

2017-11-29 Thread Peter Xu
On Thu, Nov 30, 2017 at 03:02:48PM +1100, David Gibson wrote: > On Wed, Nov 29, 2017 at 12:38:00PM +0200, Marcel Apfelbaum wrote: > > On 29/11/2017 10:46, David Gibson wrote: > > > include/hw/pci/pci_bus.h is now very small and can only safely be included > > > after hw/pci/pci.h. So, just fold it

Re: [Qemu-devel] [for-2.12 3/7] pci: Fold pci_bus.h into pci.h

2017-11-29 Thread David Gibson
On Wed, Nov 29, 2017 at 12:38:00PM +0200, Marcel Apfelbaum wrote: > On 29/11/2017 10:46, David Gibson wrote: > > include/hw/pci/pci_bus.h is now very small and can only safely be included > > after hw/pci/pci.h. So, just fold it into pci.h. > > > > I don't get the benefit from merging the header

Re: [Qemu-devel] [for-2.12 3/7] pci: Fold pci_bus.h into pci.h

2017-11-29 Thread Marcel Apfelbaum
On 29/11/2017 10:46, David Gibson wrote: include/hw/pci/pci_bus.h is now very small and can only safely be included after hw/pci/pci.h. So, just fold it into pci.h. I don't get the benefit from merging the header files. I would go the other way around and find stuff specific to pci_bus and ad

[Qemu-devel] [for-2.12 3/7] pci: Fold pci_bus.h into pci.h

2017-11-29 Thread David Gibson
include/hw/pci/pci_bus.h is now very small and can only safely be included after hw/pci/pci.h. So, just fold it into pci.h. Signed-off-by: David Gibson --- hw/acpi/pcihp.c | 1 - hw/i386/acpi-build.c| 1 - hw/i386/amd_iommu.h | 1 - hw/i386