Got your point.
Ok, I will roll back the change
Thanks
Feng
-Original Message-
From: Busch, Keith
Sent: Wednesday, June 03, 2015 22:47
To: Tian, Feng; Laszlo Ersek
Cc: edk2-de...@lists.sourceforge.net; Anbazhagan, Baraneedharan; qemu devel list
Subject: RE: [edk2] NVMe question
Sectio
Section 3.1.5, for IOCQES and IOSQES:
"The required and maximum values for this field are specified in the Identify
Controller data structure in Figure 90 for each I/O Command Set. The value is
in bytes and is specified as a power of two (2^n)."
If you're not setting these values, I assume you'
Hi, Keith
I agree your explanation does make sense.
But could you let me know where speaks the host driver must initialize these
two fields of CC register before any I/O operation in NVMe spec?
Thanks
Feng
-Original Message-
From: Busch, Keith
Sent: Wednesday, June 03, 2015 03:11
To:
Hi,
On Tue, 2 Jun 2015, Laszlo Ersek wrote:
removed the nonzero initialization of Cc.Iosqes (submission queue size?)
and Cc.Iocqes (completion queue size?) in function
NvmeEnableController(). And the removal of these field initializations
seems to cause the early sanity check in QEMU's nvme_star
On 06/02/15 09:19, Tian, Feng wrote:
> Thanks for the info.
>
>
>
> I didn’t test it on NVMe-Qemu, I just run the change on a real
> production. I will do bigger scope test to see if it’s valuable to add
> it back.
This email thread is a perfect example why top-posting is a horrible
practice.