Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-07-12 Thread Eric Blake
On 06/17/2013 08:01 AM, Gerd Hoffmann wrote: > Adds a screendump-device qmp command, which has an additional 'device' > parameter. This way it is possible to specify the device you want a > screendump from. > > For the hmp monitor an optional device parameter has been added to the > esisting scre

Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-07-12 Thread Eric Blake
On 06/18/2013 03:24 AM, Gerd Hoffmann wrote: >> > We have a job API in the block layer. Would it make sense to have a >> > QMP-level job interface? >> > I'd agree with this. > Something like the attached patch? Which is just the bare minimum I'll > need for screendump. Basically a one

Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-06-25 Thread Gerd Hoffmann
Hi, > Maybe we really should do a proper QMP jobs API. Using a BH makes sense > for the screenshot case but is orthogonal to the QMP job API. I'll drop that from my todo list for now. No way I can finish this off before my family summer vacation. I'm also hoping that someone who knows qapi +

Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-06-18 Thread Stefan Hajnoczi
On Tue, Jun 18, 2013 at 03:24:33PM +0200, Gerd Hoffmann wrote: > Hi, > > >> Something like the attached patch? Which is just the bare minimum I'll > >> need for screendump. Basically a one-off bottom half with some monitor > >> infrastructure (job id, error handling). So it isn't for big jobs

Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-06-18 Thread Gerd Hoffmann
Hi, >> Something like the attached patch? Which is just the bare minimum I'll >> need for screendump. Basically a one-off bottom half with some monitor >> infrastructure (job id, error handling). So it isn't for big jobs, but >> for small jobs which have to wait for something before they exec

Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-06-18 Thread Luiz Capitulino
On Tue, 18 Jun 2013 11:24:54 +0200 Gerd Hoffmann wrote: > On 06/17/13 16:50, Luiz Capitulino wrote: > >>> > > +struct screendump_job { > >>> > > +QEMUBH *bh; > >>> > > +QemuConsole *con; > >>> > > +char *filename; > >>> > > +}; > >> > > >> > We have a job API in the block layer. Wou

Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-06-18 Thread Gerd Hoffmann
On 06/17/13 16:50, Luiz Capitulino wrote: >>> > > +struct screendump_job { >>> > > +QEMUBH *bh; >>> > > +QemuConsole *con; >>> > > +char *filename; >>> > > +}; >> > >> > We have a job API in the block layer. Would it make sense to have a >> > QMP-level job interface? > I'd agree with

Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 09:43:07 -0500 Anthony Liguori wrote: > Gerd Hoffmann writes: > > > Adds a screendump-device qmp command, which has an additional 'device' > > parameter. This way it is possible to specify the device you want a > > screendump from. > > > > For the hmp monitor an optional de

Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-06-17 Thread Anthony Liguori
Gerd Hoffmann writes: > Adds a screendump-device qmp command, which has an additional 'device' > parameter. This way it is possible to specify the device you want a > screendump from. > > For the hmp monitor an optional device parameter has been added to the > esisting screendump command. > > ht

[Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-06-17 Thread Gerd Hoffmann
Adds a screendump-device qmp command, which has an additional 'device' parameter. This way it is possible to specify the device you want a screendump from. For the hmp monitor an optional device parameter has been added to the esisting screendump command. https://bugzilla.redhat.com/show_bug.cgi