Re: [Qemu-devel] [RfC PATCH] gtk: switch to gtk3 by default, depricate gtk2.

2016-07-07 Thread Gerd Hoffmann
Hi, > > > +echo "If it is really your intention to build qemu with gtk2 > > > re-run" > > > +echo "configure with --with-gtkabi=2.0." > > > +echo "" > > > +exit 1 > > > fi > > > fi > > > > I'm not really convinced that we should do this, though. Generally

Re: [Qemu-devel] [RfC PATCH] gtk: switch to gtk3 by default, depricate gtk2.

2016-07-07 Thread Daniel P. Berrange
On Thu, Jul 07, 2016 at 03:52:20PM +0100, Peter Maydell wrote: > On 7 July 2016 at 15:27, Gerd Hoffmann wrote: > > This patch drops gtk version detection. gtk3 is used unless you > > explicitly ask for gtk2. Additionally configure prints an error > > message in case it finds gtk2 but not gtk3. >

Re: [Qemu-devel] [RfC PATCH] gtk: switch to gtk3 by default, depricate gtk2.

2016-07-07 Thread Peter Maydell
On 7 July 2016 at 15:27, Gerd Hoffmann wrote: > This patch drops gtk version detection. gtk3 is used unless you > explicitly ask for gtk2. Additionally configure prints an error > message in case it finds gtk2 but not gtk3. > > Old behavior: > only gtk3 installed -- use gtk3 > both gtk2+

Re: [Qemu-devel] [RfC PATCH] gtk: switch to gtk3 by default, depricate gtk2.

2016-07-07 Thread Daniel P. Berrange
On Thu, Jul 07, 2016 at 04:27:40PM +0200, Gerd Hoffmann wrote: > This patch drops gtk version detection. gtk3 is used unless you > explicitly ask for gtk2. Additionally configure prints an error > message in case it finds gtk2 but not gtk3. > > Old behavior: > only gtk3 installed -- use gt

[Qemu-devel] [RfC PATCH] gtk: switch to gtk3 by default, depricate gtk2.

2016-07-07 Thread Gerd Hoffmann
This patch drops gtk version detection. gtk3 is used unless you explicitly ask for gtk2. Additionally configure prints an error message in case it finds gtk2 but not gtk3. Old behavior: only gtk3 installed -- use gtk3 both gtk2+3 installed -- use gtk2 only gtk2 installed -- use g