Re: [Qemu-devel] [RISU v2 07/11] test_i386: change syntax from nasm to gas

2019-05-21 Thread Jan Bobek
On 5/21/19 12:56 PM, Richard Henderson wrote: > On 5/21/19 12:48 PM, Jan Bobek wrote: >> I get the same behavior, but it only occurs on 32bit builds of >> RISU. Specifically, in risu_reginfo_i386.c, lines 172--178: >> >> for (i = 0; i < nvecregs; ++i) { >> #ifdef __x86_64__ >> memcpy(&r

Re: [Qemu-devel] [RISU v2 07/11] test_i386: change syntax from nasm to gas

2019-05-21 Thread Richard Henderson
On 5/21/19 12:48 PM, Jan Bobek wrote: > I get the same behavior, but it only occurs on 32bit builds of > RISU. Specifically, in risu_reginfo_i386.c, lines 172--178: > > for (i = 0; i < nvecregs; ++i) { > #ifdef __x86_64__ > memcpy(&ri->vregs[i], &fp->xmm_space[i], 16); > #else >

Re: [Qemu-devel] [RISU v2 07/11] test_i386: change syntax from nasm to gas

2019-05-21 Thread Jan Bobek
On 5/21/19 11:30 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 5/21/19 5:08 AM, Alex Bennée wrote: > We probably need to zero or reset the xmm regs both in the test and when > risugen dumps it's preamble. > That gets fixed later in the series. >>> >>> So it d

Re: [Qemu-devel] [RISU v2 07/11] test_i386: change syntax from nasm to gas

2019-05-21 Thread Alex Bennée
Richard Henderson writes: > On 5/21/19 5:08 AM, Alex Bennée wrote: We probably need to zero or reset the xmm regs both in the test and when risugen dumps it's preamble. >>> >>> That gets fixed later in the series. >> >> So it does, but I'm still seeing the test fail when played b

Re: [Qemu-devel] [RISU v2 07/11] test_i386: change syntax from nasm to gas

2019-05-21 Thread Richard Henderson
On 5/21/19 5:08 AM, Alex Bennée wrote: >>> We probably need to zero or reset the xmm regs both in the test and when >>> risugen dumps it's preamble. >>> >> >> That gets fixed later in the series. > > So it does, but I'm still seeing the test fail when played back :-/ Um, no, I mean this test is e

Re: [Qemu-devel] [RISU v2 07/11] test_i386: change syntax from nasm to gas

2019-05-21 Thread Alex Bennée
Richard Henderson writes: > On Mon, May 20, 2019, 08:17 Alex Bennée wrote: > >> >> Jan Bobek writes: >> >> > This allows us to drop dependency on NASM and build the test image >> > with GCC only. Adds support for x86_64, too. >> >> ./risu --master -t run.out test_i386.bin >> >> and then: >>

Re: [Qemu-devel] [RISU v2 07/11] test_i386: change syntax from nasm to gas

2019-05-20 Thread Richard Henderson
On Mon, May 20, 2019, 08:17 Alex Bennée wrote: > > Jan Bobek writes: > > > This allows us to drop dependency on NASM and build the test image > > with GCC only. Adds support for x86_64, too. > > ./risu --master -t run.out test_i386.bin > > and then: > > ./risu -t run.out test_i386.bin > > Gi

Re: [Qemu-devel] [RISU v2 07/11] test_i386: change syntax from nasm to gas

2019-05-20 Thread Alex Bennée
Jan Bobek writes: > This allows us to drop dependency on NASM and build the test image > with GCC only. Adds support for x86_64, too. ./risu --master -t run.out test_i386.bin and then: ./risu -t run.out test_i386.bin Gives: loading test image test_i386.bin... starting apprentice im

Re: [Qemu-devel] [RISU v2 07/11] test_i386: change syntax from nasm to gas

2019-05-18 Thread Richard Henderson
On 5/17/19 3:44 PM, Jan Bobek wrote: > This allows us to drop dependency on NASM and build the test image > with GCC only. Adds support for x86_64, too. > > Suggested-by: Richard Henderson > Signed-off-by: Jan Bobek > --- > Makefile| 3 +++ > test_i386.S | 41 ++

[Qemu-devel] [RISU v2 07/11] test_i386: change syntax from nasm to gas

2019-05-17 Thread Jan Bobek
This allows us to drop dependency on NASM and build the test image with GCC only. Adds support for x86_64, too. Suggested-by: Richard Henderson Signed-off-by: Jan Bobek --- Makefile| 3 +++ test_i386.S | 41 + test_i386.s | 27 ---